Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045128Retail ModulesGift cards and gift voucherspublic2020-09-24 10:102020-10-08 12:40
Reporterjavietxe 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045128: Expiration date of the giftcard not calculated in the POS
DescriptionThe expiration date of the giftcard is calculated while the transaction is being done to the backend. This makes that the expiration date cannot be printed by the POS.
Steps To ReproduceSet in the organization the "Credit Note expiration days"

Do a return as Gift Cards
Proposed SolutionCalculate the expiration date in the POS and send it in the payment.

In order to do this, the organization field em_gncv_creditnote_lifetime should be sent to the POS.

When creating the gift card, the expiration date is calculated with this value, set in the gift card and send it in the payment to the backend
Additional Information
TagsNo tags attached.
Relationships
related to defect 0051882 closed radhakrishnan Wrong expiration date printed in a Credit Note partially used 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-09-24 10:10javietxeNew Issue
2020-09-24 10:10javietxeAssigned To => Retail
2020-09-24 10:10javietxeResolution time => 1602712800
2020-09-24 10:10javietxeTriggers an Emergency Pack => No
2020-10-05 18:01ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2020-10-05 18:02ranjith_qualiantech_comStatusnew => scheduled
2020-10-07 09:17ranjith_qualiantech_comNote Added: 0123585
2020-10-08 07:25hgbotNote Added: 0123610
2020-10-08 12:40hgbotResolutionopen => fixed
2020-10-08 12:40hgbotStatusscheduled => closed
2020-10-08 12:40hgbotNote Added: 0123619
2020-10-08 12:40hgbotNote Added: 0123620
2023-03-24 10:33ngarciaRelationship addedrelated to 0051882

Notes
(0123585)
ranjith_qualiantech_com   
2020-10-07 09:17   
Caused by indexed db add payment changes
Payment data is converted to json by parsing as string. So Date object is converted to String
commit: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/197a764cb7f7eb64a9cdf82a44a5de5888e5ba4b#c7e7b1a1803a89252d22c91692bd17768ca5938e_7733_7608 [^]
(0123610)
hgbot   
2020-10-08 07:25   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/27 [^]
(0123619)
hgbot   
2020-10-08 12:40   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 9c6a33f75cf65fc50906bd945bb592b2e6635186
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-10-08T10:54:43+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/9c6a33f75cf65fc50906bd945bb592b2e6635186 [^]

Fixed ISSUE-45128: Updated ExpirationDate calculation when printing credit note
* When adding payment, expiration date is saved as string instead of date object. So date should be parsed and formatted before printing

---
M web/org.openbravo.retail.giftcards/js/hooks/printGiftCardPrePrintHook.js
---
(0123620)
hgbot   
2020-10-08 12:40   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/27 [^]