Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0044922
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajorhave not tried2020-08-28 16:272020-09-07 13:52
ReporterjarmendarizView Statuspublic 
Assigned Tojarmendariz 
PriorityhighResolutionfixedFixed in VersionRR20Q4
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0044922: Undo mechanism is not working for new state actions

DescriptionOlder Ticket actions also added to the Ticket an undo function to be executed when tapping the 'Undo' button in the WebPOS and reverts the Ticket to its state prior to the action. This functionality is lost when refactoring Ticket actions to use the new infrastructure.
Steps To ReproduceWhen adding a product to the Ticket, the 'Undo' button should appear and, when pressed, the product should disappear and update amounts/discounts/taxes... in order to leave the Ticket in its previous state
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0122446)
hgbot (developer)
2020-08-29 16:18

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 9723aba5ec4c4e24d6e1188a8ac459e7f5254344
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 2020-08-29T16:14:28+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/9723aba5ec4c4e24d6e1188a8ac459e7f5254344 [^]

Fixed ISSUE-44922: Implemented undo mechanism for state actions

MR: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/57 [^]

---
A web-test/model/application-state/StateUndo.functional.test.js
M web-test/model/application-state/StateAPI.test.js
M web-test/model/application-state/StatePersistence.functional.test.js
M web-test/model/application-state/compat/StateBackwardCompatibility-infra.test.js
M web/org.openbravo.mobile.core/app/model/application-state/State.js
M web/org.openbravo.mobile.core/app/model/application-state/StateAPI.js
M web/org.openbravo.mobile.core/app/model/application-state/StateBackwardCompatibility.js
---
(0122447)
hgbot (developer)
2020-08-29 16:19

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 3dfa91e940eb2f10e89c85a82e353ffb40a4eef5
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 2020-08-29T16:16:48+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/3dfa91e940eb2f10e89c85a82e353ffb40a4eef5 [^]

Related to ISSUE-44922: Implemented undo mechanism for state actions

MR: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merg$ [^]

---
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/Ticket.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/scan.js
---
(0122448)
hgbot (developer)
2020-08-29 16:20

 Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: de59bf2dddd826e358b0f562f760113d1a934a91
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 2020-08-29T16:17:45+02:00
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/de59bf2dddd826e358b0f562f760113d1a934a91 [^]

Related to ISSUE-44922: Implemented undo mechanism for state actions

MR: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merg$ [^]

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I34300_VerifyReceiptDiscountUndo.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I28728_UndoButtonRemovesInformation.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I33029_VerifyUndoForQuotation.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I34416_VerifyUndoOnDeleteLineWithPref.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I33078_VerifyUndoOnNegateButton.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I33443_VerifyUndoOnNegateButton.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/DeleteTicketWithDeletedLines.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/rfid/AddMultipleSameRFID.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/rfid/DisableScaningFocusRFID.java
---
(0122498)
hgbot (developer)
2020-09-01 08:53

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 83e9649475de668011809c44184e82bf66322b4f
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 2020-09-01T08:52:46+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/83e9649475de668011809c44184e82bf66322b4f [^]

Related to ISSUE-44922: Setting undo property only to undoable models. This also fixes unit tests

---
M web/org.openbravo.mobile.core/app/model/application-state/StateBackwardCompatibility.js
---

- Issue History
Date Modified Username Field Change
2020-08-28 16:27 jarmendariz New Issue
2020-08-28 16:27 jarmendariz Assigned To => jarmendariz
2020-08-28 16:27 jarmendariz Triggers an Emergency Pack => No
2020-08-28 16:27 jarmendariz Status new => scheduled
2020-08-28 16:27 jarmendariz Review Assigned To => marvintm
2020-08-29 16:18 hgbot Resolution open => fixed
2020-08-29 16:18 hgbot Status scheduled => resolved
2020-08-29 16:18 hgbot Fixed in Version => RR20Q4
2020-08-29 16:18 hgbot Note Added: 0122446
2020-08-29 16:19 hgbot Note Added: 0122447
2020-08-29 16:20 hgbot Note Added: 0122448
2020-09-01 08:53 hgbot Note Added: 0122498
2020-09-07 13:52 marvintm Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker