Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044922Retail ModulesWeb POSpublic2020-08-28 16:272020-09-07 13:52
Reporterjarmendariz 
Assigned Tojarmendariz 
PriorityhighSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0044922: Undo mechanism is not working for new state actions
DescriptionOlder Ticket actions also added to the Ticket an undo function to be executed when tapping the 'Undo' button in the WebPOS and reverts the Ticket to its state prior to the action. This functionality is lost when refactoring Ticket actions to use the new infrastructure.
Steps To ReproduceWhen adding a product to the Ticket, the 'Undo' button should appear and, when pressed, the product should disappear and update amounts/discounts/taxes... in order to leave the Ticket in its previous state
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-08-28 16:27jarmendarizNew Issue
2020-08-28 16:27jarmendarizAssigned To => jarmendariz
2020-08-28 16:27jarmendarizTriggers an Emergency Pack => No
2020-08-28 16:27jarmendarizStatusnew => scheduled
2020-08-28 16:27jarmendarizReview Assigned To => marvintm
2020-08-29 16:18hgbotResolutionopen => fixed
2020-08-29 16:18hgbotStatusscheduled => resolved
2020-08-29 16:18hgbotFixed in Version => RR20Q4
2020-08-29 16:18hgbotNote Added: 0122446
2020-08-29 16:19hgbotNote Added: 0122447
2020-08-29 16:20hgbotNote Added: 0122448
2020-09-01 08:53hgbotNote Added: 0122498
2020-09-07 13:52marvintmStatusresolved => closed

Notes
(0122446)
hgbot   
2020-08-29 16:18   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 9723aba5ec4c4e24d6e1188a8ac459e7f5254344
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 2020-08-29T16:14:28+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/9723aba5ec4c4e24d6e1188a8ac459e7f5254344 [^]

Fixed ISSUE-44922: Implemented undo mechanism for state actions

MR: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/57 [^]

---
A web-test/model/application-state/StateUndo.functional.test.js
M web-test/model/application-state/StateAPI.test.js
M web-test/model/application-state/StatePersistence.functional.test.js
M web-test/model/application-state/compat/StateBackwardCompatibility-infra.test.js
M web/org.openbravo.mobile.core/app/model/application-state/State.js
M web/org.openbravo.mobile.core/app/model/application-state/StateAPI.js
M web/org.openbravo.mobile.core/app/model/application-state/StateBackwardCompatibility.js
---
(0122447)
hgbot   
2020-08-29 16:19   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 3dfa91e940eb2f10e89c85a82e353ffb40a4eef5
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 2020-08-29T16:16:48+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/3dfa91e940eb2f10e89c85a82e353ffb40a4eef5 [^]

Related to ISSUE-44922: Implemented undo mechanism for state actions

MR: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merg$ [^]

---
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/Ticket.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/scan.js
---
(0122448)
hgbot   
2020-08-29 16:20   
Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: de59bf2dddd826e358b0f562f760113d1a934a91
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 2020-08-29T16:17:45+02:00
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/de59bf2dddd826e358b0f562f760113d1a934a91 [^]

Related to ISSUE-44922: Implemented undo mechanism for state actions

MR: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merg$ [^]

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I34300_VerifyReceiptDiscountUndo.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I28728_UndoButtonRemovesInformation.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I33029_VerifyUndoForQuotation.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I34416_VerifyUndoOnDeleteLineWithPref.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I33078_VerifyUndoOnNegateButton.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I33443_VerifyUndoOnNegateButton.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/DeleteTicketWithDeletedLines.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/rfid/AddMultipleSameRFID.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/rfid/DisableScaningFocusRFID.java
---
(0122498)
hgbot   
2020-09-01 08:53   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 83e9649475de668011809c44184e82bf66322b4f
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 2020-09-01T08:52:46+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/83e9649475de668011809c44184e82bf66322b4f [^]

Related to ISSUE-44922: Setting undo property only to undoable models. This also fixes unit tests

---
M web/org.openbravo.mobile.core/app/model/application-state/StateBackwardCompatibility.js
---