Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0044888 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | minor | have not tried | 2020-08-25 15:00 | 2020-09-04 07:28 | |||
| Reporter | aferraz | View Status | public | |||||
| Assigned To | ranjith_qualiantech_com | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RR20Q4 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | approved | |||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0044888: Add info to no tax found error in tax engine | |||||||
| Description | Add error subclass to tax engine in order to add user readable error message in case 'No tax found for line' error is thrown. | |||||||
| Steps To Reproduce | Run CheckShippingAddressMandatory test. Check "Cannot calculate taxes for a line with 1 x Avalanche transceiver" error is shown. Check this error is thrown from TicketUtils.calculateDiscountsAndTaxes(), after parsing the error thrown from tax-rules.js. | |||||||
| Proposed Solution | Create Error subclass named TaxEngineError, similar to https://gitlab.com/openbravo/projects/retail/pmods/org.openbravo.mobile.core/-/blob/master/web/org.openbravo.mobile.core/app/exception/TranslatableError.js [^] In tax-rules.js, throw TaxEngineError instead of Error, adding needed information ('No tax found for line' message and line id.) In TicketUtils.calculateDiscountsAndTaxes catch, read needed information from TaxEngineError, instead of parsing error message. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0122360) hgbot (developer) 2020-08-26 12:49 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/71 [^] |
|
(0122361) hgbot (developer) 2020-08-26 12:49 |
Merge Request created: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/31 [^] |
|
(0122632) hgbot (developer) 2020-09-04 07:28 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: 23c255af7e604dbaa99dfb146448761494699e54 Author: Ranjith S R <ranjith@qualiantech.com> Date: 2020-09-04T05:28:43+00:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/23c255af7e604dbaa99dfb146448761494699e54 [^] Fixed ISSUE-44888: Added Error Subclass for TaxEngine --- A web/org.openbravo.retail.posterminal/app/model/business-logic/taxes-engine/engine/tax-error.js M src-db/database/sourcedata/AD_MESSAGE.xml M src/org/openbravo/retail/posterminal/TaxesEngineAppComponentProvider.java M web/org.openbravo.retail.posterminal/app/model/business-logic/taxes-engine/engine/tax-rules.js M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/TicketUtils.js --- |
|
(0122633) hgbot (developer) 2020-09-04 07:28 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/71 [^] |
|
(0122634) hgbot (developer) 2020-09-04 07:28 |
Repository: https://gitlab.com/openbravo/ci/mobile-test [^] Changeset: 3c8ec67d228722375c169b88349aa20f41cd98c3 Author: Ranjith S R <ranjith@qualiantech.com> Date: 2020-09-04T05:28:48+00:00 URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/3c8ec67d228722375c169b88349aa20f41cd98c3 [^] Verifies ISSUE-44888: Modified LineTax Automated tests --- M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/customercreation/CheckShippingAddressMandatory.java M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I35829_VerifyOrderLineNotTaxes.java M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I36071_VerifyNotServicesShownWhenProductNotAdd.java --- |
|
(0122635) hgbot (developer) 2020-09-04 07:28 |
Merge request merged: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/31 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2020-08-25 15:00 | aferraz | New Issue | |
| 2020-08-25 15:00 | aferraz | Assigned To | => Retail |
| 2020-08-25 15:00 | aferraz | OBNetwork customer | => No |
| 2020-08-25 15:00 | aferraz | Triggers an Emergency Pack | => No |
| 2020-08-26 06:19 | ranjith_qualiantech_com | Assigned To | Retail => ranjith_qualiantech_com |
| 2020-08-26 06:19 | ranjith_qualiantech_com | Status | new => scheduled |
| 2020-08-26 12:49 | hgbot | Merge Request Status | => open |
| 2020-08-26 12:49 | hgbot | Note Added: 0122360 | |
| 2020-08-26 12:49 | hgbot | Note Added: 0122361 | |
| 2020-09-04 07:28 | hgbot | Merge Request Status | open => approved |
| 2020-09-04 07:28 | hgbot | Resolution | open => fixed |
| 2020-09-04 07:28 | hgbot | Status | scheduled => closed |
| 2020-09-04 07:28 | hgbot | Fixed in Version | => RR20Q4 |
| 2020-09-04 07:28 | hgbot | Note Added: 0122632 | |
| 2020-09-04 07:28 | hgbot | Note Added: 0122633 | |
| 2020-09-04 07:28 | hgbot | Note Added: 0122634 | |
| 2020-09-04 07:28 | hgbot | Note Added: 0122635 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |