Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044888Retail ModulesWeb POSpublic2020-08-25 15:002020-09-04 07:28
Reporteraferraz 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q4 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0044888: Add info to no tax found error in tax engine
DescriptionAdd error subclass to tax engine in order to add user readable error message in case 'No tax found for line' error is thrown.
Steps To ReproduceRun CheckShippingAddressMandatory test.
Check "Cannot calculate taxes for a line with 1 x Avalanche transceiver" error is shown.
Check this error is thrown from TicketUtils.calculateDiscountsAndTaxes(), after parsing the error thrown from tax-rules.js.
Proposed SolutionCreate Error subclass named TaxEngineError, similar to https://gitlab.com/openbravo/projects/retail/pmods/org.openbravo.mobile.core/-/blob/master/web/org.openbravo.mobile.core/app/exception/TranslatableError.js [^]

In tax-rules.js, throw TaxEngineError instead of Error, adding needed information ('No tax found for line' message and line id.)

In TicketUtils.calculateDiscountsAndTaxes catch, read needed information from TaxEngineError, instead of parsing error message.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-08-25 15:00aferrazNew Issue
2020-08-25 15:00aferrazAssigned To => Retail
2020-08-25 15:00aferrazOBNetwork customer => No
2020-08-25 15:00aferrazTriggers an Emergency Pack => No
2020-08-26 06:19ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2020-08-26 06:19ranjith_qualiantech_comStatusnew => scheduled
2020-08-26 12:49hgbotMerge Request Status => open
2020-08-26 12:49hgbotNote Added: 0122360
2020-08-26 12:49hgbotNote Added: 0122361
2020-09-04 07:28hgbotMerge Request Statusopen => approved
2020-09-04 07:28hgbotResolutionopen => fixed
2020-09-04 07:28hgbotStatusscheduled => closed
2020-09-04 07:28hgbotFixed in Version => RR20Q4
2020-09-04 07:28hgbotNote Added: 0122632
2020-09-04 07:28hgbotNote Added: 0122633
2020-09-04 07:28hgbotNote Added: 0122634
2020-09-04 07:28hgbotNote Added: 0122635

Notes
(0122360)
hgbot   
2020-08-26 12:49   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/71 [^]
(0122361)
hgbot   
2020-08-26 12:49   
Merge Request created: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/31 [^]
(0122632)
hgbot   
2020-09-04 07:28   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 23c255af7e604dbaa99dfb146448761494699e54
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-09-04T05:28:43+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/23c255af7e604dbaa99dfb146448761494699e54 [^]

Fixed ISSUE-44888: Added Error Subclass for TaxEngine

---
A web/org.openbravo.retail.posterminal/app/model/business-logic/taxes-engine/engine/tax-error.js
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/retail/posterminal/TaxesEngineAppComponentProvider.java
M web/org.openbravo.retail.posterminal/app/model/business-logic/taxes-engine/engine/tax-rules.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/TicketUtils.js
---
(0122633)
hgbot   
2020-09-04 07:28   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/71 [^]
(0122634)
hgbot   
2020-09-04 07:28   
Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: 3c8ec67d228722375c169b88349aa20f41cd98c3
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-09-04T05:28:48+00:00
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/3c8ec67d228722375c169b88349aa20f41cd98c3 [^]

Verifies ISSUE-44888: Modified LineTax Automated tests

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/customercreation/CheckShippingAddressMandatory.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I35829_VerifyOrderLineNotTaxes.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I36071_VerifyNotServicesShownWhenProductNotAdd.java
---
(0122635)
hgbot   
2020-09-04 07:28   
Merge request merged: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/31 [^]