Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0044814
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminorhave not tried2020-08-13 18:202020-08-28 08:13
ReportercaristuView Statuspublic 
Assigned ToRetail 
PriorityurgentResolutionfixedFixed in VersionRR20Q4
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0044814: The location of some new files is not following the standard convention

DescriptionSome new files of the "new" code are located in a place that does not follow the standard convention. These files are:

In mobile.core:

- app/externalbp: (https://gitlab.com/openbravo/projects/retail/pmods/org.openbravo.mobile.core/-/tree/master/web/org.openbravo.mobile.core/app/externalbp [^]) --> The files inside that folder should be moved inside a new folder to keep external integrations, for example: app/integrations/external-business-partner

In posterminal:

- current files inside app/model/business-object/business-partner)(https://gitlab.com/openbravo/projects/retail/pmods/org.openbravo.retail.posterminal/-/tree/master/web/org.openbravo.retail.posterminal/app/model/business-object/business-partner [^]) should be moved to an actions folder because they are defining actions: app/model/business-object/business-partner/actions
Steps To Reproduce.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0122243)
hgbot (developer)
2020-08-21 13:06

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/55 [^]
(0122245)
hgbot (developer)
2020-08-21 13:14

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/68 [^]
(0122401)
hgbot (developer)
2020-08-28 08:10

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/55 [^]
(0122402)
hgbot (developer)
2020-08-28 08:10

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: d1d049324a694de4a62e25249952a00a060a5617
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 2020-08-28T08:08:04+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/d1d049324a694de4a62e25249952a00a060a5617 [^]

fixed ISSUE-44814: move external BP files to an standard location

---
A web-test/integration/external-business-partner/ExternalBusinessPartner.test.js
A web-test/integration/external-business-partner/ExternalBusinessPartnerAPI.test.js
A web-test/integration/external-business-partner/ExternalBusinessPartnerListViewData.test.js
A web-test/integration/external-business-partner/ExternalBusinessPartnerViewData.test.js
A web-test/integration/external-business-partner/ebp-test-base.js
A web/org.openbravo.mobile.core/app/integration/external-business-partner/ExternalBusinessPartner.js
A web/org.openbravo.mobile.core/app/integration/external-business-partner/ExternalBusinessPartnerAPI.js
A web/org.openbravo.mobile.core/app/integration/external-business-partner/ExternalBusinessPartnerListViewData.js
A web/org.openbravo.mobile.core/app/integration/external-business-partner/ExternalBusinessPartnerRepository.js
A web/org.openbravo.mobile.core/app/integration/external-business-partner/ExternalBusinessPartnerViewData.js
M src/org/openbravo/mobile/core/MobileCoreComponentProvider.java
---
(0122403)
hgbot (developer)
2020-08-28 08:13

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 11892ec428f43f7456baef648f3354bec356350f
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 2020-08-28T08:11:35+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/11892ec428f43f7456baef648f3354bec356350f [^]

related to ISSUE-44814: use standard location for BP related actions

---
A web-test/model/business-object/business-partner/actions/SynchronizeBusinessPartner.test.js
A web-test/model/business-object/business-partner/actions/SynchronizeBusinessPartnerLocation.test.js
A web/org.openbravo.retail.posterminal/app/model/business-object/business-partner/actions/SynchronizeBusinessPartner.js
A web/org.openbravo.retail.posterminal/app/model/business-object/business-partner/actions/SynchronizeBusinessPartnerLocation.js
M src/org/openbravo/retail/posterminal/OBPOSComponentProvider.java
---
(0122404)
hgbot (developer)
2020-08-28 08:13

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/68 [^]

- Issue History
Date Modified Username Field Change
2020-08-13 18:20 caristu New Issue
2020-08-13 18:20 caristu Assigned To => Retail
2020-08-13 18:20 caristu OBNetwork customer => No
2020-08-13 18:20 caristu Triggers an Emergency Pack => No
2020-08-21 13:06 hgbot Merge Request Status => open
2020-08-21 13:06 hgbot Note Added: 0122243
2020-08-21 13:14 hgbot Note Added: 0122245
2020-08-27 14:39 hgbot Merge Request Status open => approved
2020-08-28 08:10 hgbot Resolution open => fixed
2020-08-28 08:10 hgbot Status new => closed
2020-08-28 08:10 hgbot Note Added: 0122401
2020-08-28 08:10 hgbot Fixed in Version => RR20Q4
2020-08-28 08:10 hgbot Note Added: 0122402
2020-08-28 08:13 hgbot Note Added: 0122403
2020-08-28 08:13 hgbot Note Added: 0122404

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker