Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044814Retail ModulesWeb POSpublic2020-08-13 18:202020-08-28 08:13
Reportercaristu 
Assigned ToRetail 
PriorityurgentSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q4 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0044814: The location of some new files is not following the standard convention
DescriptionSome new files of the "new" code are located in a place that does not follow the standard convention. These files are:

In mobile.core:

- app/externalbp: (https://gitlab.com/openbravo/projects/retail/pmods/org.openbravo.mobile.core/-/tree/master/web/org.openbravo.mobile.core/app/externalbp [^]) --> The files inside that folder should be moved inside a new folder to keep external integrations, for example: app/integrations/external-business-partner

In posterminal:

- current files inside app/model/business-object/business-partner)(https://gitlab.com/openbravo/projects/retail/pmods/org.openbravo.retail.posterminal/-/tree/master/web/org.openbravo.retail.posterminal/app/model/business-object/business-partner [^]) should be moved to an actions folder because they are defining actions: app/model/business-object/business-partner/actions
Steps To Reproduce.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-08-13 18:20caristuNew Issue
2020-08-13 18:20caristuAssigned To => Retail
2020-08-13 18:20caristuTriggers an Emergency Pack => No
2020-08-21 13:06hgbotNote Added: 0122243
2020-08-21 13:14hgbotNote Added: 0122245
2020-08-28 08:10hgbotResolutionopen => fixed
2020-08-28 08:10hgbotStatusnew => closed
2020-08-28 08:10hgbotNote Added: 0122401
2020-08-28 08:10hgbotFixed in Version => RR20Q4
2020-08-28 08:10hgbotNote Added: 0122402
2020-08-28 08:13hgbotNote Added: 0122403
2020-08-28 08:13hgbotNote Added: 0122404

Notes
(0122243)
hgbot   
2020-08-21 13:06   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/55 [^]
(0122245)
hgbot   
2020-08-21 13:14   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/68 [^]
(0122401)
hgbot   
2020-08-28 08:10   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/55 [^]
(0122402)
hgbot   
2020-08-28 08:10   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: d1d049324a694de4a62e25249952a00a060a5617
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 2020-08-28T08:08:04+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/d1d049324a694de4a62e25249952a00a060a5617 [^]

fixed ISSUE-44814: move external BP files to an standard location

---
A web-test/integration/external-business-partner/ExternalBusinessPartner.test.js
A web-test/integration/external-business-partner/ExternalBusinessPartnerAPI.test.js
A web-test/integration/external-business-partner/ExternalBusinessPartnerListViewData.test.js
A web-test/integration/external-business-partner/ExternalBusinessPartnerViewData.test.js
A web-test/integration/external-business-partner/ebp-test-base.js
A web/org.openbravo.mobile.core/app/integration/external-business-partner/ExternalBusinessPartner.js
A web/org.openbravo.mobile.core/app/integration/external-business-partner/ExternalBusinessPartnerAPI.js
A web/org.openbravo.mobile.core/app/integration/external-business-partner/ExternalBusinessPartnerListViewData.js
A web/org.openbravo.mobile.core/app/integration/external-business-partner/ExternalBusinessPartnerRepository.js
A web/org.openbravo.mobile.core/app/integration/external-business-partner/ExternalBusinessPartnerViewData.js
M src/org/openbravo/mobile/core/MobileCoreComponentProvider.java
---
(0122403)
hgbot   
2020-08-28 08:13   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 11892ec428f43f7456baef648f3354bec356350f
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 2020-08-28T08:11:35+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/11892ec428f43f7456baef648f3354bec356350f [^]

related to ISSUE-44814: use standard location for BP related actions

---
A web-test/model/business-object/business-partner/actions/SynchronizeBusinessPartner.test.js
A web-test/model/business-object/business-partner/actions/SynchronizeBusinessPartnerLocation.test.js
A web/org.openbravo.retail.posterminal/app/model/business-object/business-partner/actions/SynchronizeBusinessPartner.js
A web/org.openbravo.retail.posterminal/app/model/business-object/business-partner/actions/SynchronizeBusinessPartnerLocation.js
M src/org/openbravo/retail/posterminal/OBPOSComponentProvider.java
---
(0122404)
hgbot   
2020-08-28 08:13   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/68 [^]