Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0044801 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Localization Pack: Spain] CIF and NIF validator | minor | have not tried | 2020-08-12 16:48 | 2020-09-11 12:09 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | Mery Anelo | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Regression date | ||||||||
| Regression introduced by commit | ||||||||
| Regression level | ||||||||
| Review Assigned To | vmromanos | |||||||
| Regression introduced in release | ||||||||
| Summary | 0044801: SE_CIFNIF_Validator is an old-style callout and should be refactored to use SimpleCallout | |||||||
| Description | This callout is one of the few ones left over not not refactored to be SimpleCallout (issue 36067 refactored every supported module except a few one). | |||||||
| Steps To Reproduce | product/mods/org.openbravo.module.cifnifvalidator/src/org/openbravo/module/cifnifvalidator/erpCommon/ad_callouts/SE_CIFNIF_Validator.java: resultado.append("var respuesta = new Array( \n"); | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||
|
|||||||||
 Relationships |
|
Notes |
|
|
(0122096) shuehner (administrator) 2020-08-17 12:36 edited on: 2020-08-17 12:40 |
EXECUTE action of callouts is obsolete and does not work for many years. That part of the callout should be reviewed and fixed while working on this also. Note that this is in codepath trying to support old 2.50 style UI. So probably that could be just removed as no longer required. |
|
(0122698) Mery Anelo (developer) 2020-09-05 03:11 |
Test plan: - Login as System Admin - Manually associated the SE_CIFNIF_Validator callout to the TaxID column of the C_BPartner table. - Compile the Business Partner window and redeploy the application. - Login as F&B Internation Group Admin - Set values to the field "Tax ID" in "Business Partner" windows and check that you have a message when this value is wrong. |
|
(0122928) hgbot (developer) 2020-09-10 16:42 |
Merge Request created: https://gitlab.com/openbravo/product/mods/org.openbravo.module.cifnifvalidator/-/merge_requests/1 [^] |
|
(0122956) hgbot (developer) 2020-09-11 12:08 |
Repository: https://gitlab.com/openbravo/product/mods/org.openbravo.module.cifnifvalidator [^] Changeset: 6c4910cbd769d95ccefc420be5cd25f876606da5 Author: Mery Anelo <mery.anelo@smfconsulting.es> Date: 2020-09-10T11:39:59-03:00 URL: https://gitlab.com/openbravo/product/mods/org.openbravo.module.cifnifvalidator/-/commit/6c4910cbd769d95ccefc420be5cd25f876606da5 [^] Fixed BUG-44801: CIFNIF validations to SimpleCallout Format java. --- M src/org/openbravo/module/cifnifvalidator/erpCommon/ad_callouts/SE_CIFNIF_Validator.java --- |
|
(0122957) hgbot (developer) 2020-09-11 12:08 |
Repository: https://gitlab.com/openbravo/product/mods/org.openbravo.module.cifnifvalidator [^] Changeset: 17c8944083f66028aa873307efdd11ecba0921f3 Author: Mery Anelo <mery.anelo@smfconsulting.es> Date: 2020-09-10T11:41:25-03:00 URL: https://gitlab.com/openbravo/product/mods/org.openbravo.module.cifnifvalidator/-/commit/17c8944083f66028aa873307efdd11ecba0921f3 [^] Fixed BUG-44801: CIFNIF validations to SimpleCallout SE_CIFNIF_Validator transformed from old-style callout to SimpleCallout. --- M src/org/openbravo/module/cifnifvalidator/erpCommon/ad_callouts/SE_CIFNIF_Validator.java --- |
|
(0122958) hgbot (developer) 2020-09-11 12:08 |
Repository: https://gitlab.com/openbravo/product/mods/org.openbravo.module.cifnifvalidator [^] Changeset: 382dadf3b510fbe2ca4e4a1273d2907ac8593b55 Author: Víctor Martínez Romanos <victor.martinez@openbravo.com> Date: 2020-09-11T12:00:48+02:00 URL: https://gitlab.com/openbravo/product/mods/org.openbravo.module.cifnifvalidator/-/commit/382dadf3b510fbe2ca4e4a1273d2907ac8593b55 [^] Related to ISSUE-44801: Simplified code Removed useless check for Openbravo3. Use standard OBMessageUtils.messageBD() method. --- M src/org/openbravo/module/cifnifvalidator/erpCommon/ad_callouts/SE_CIFNIF_Validator.java --- |
|
(0122959) hgbot (developer) 2020-09-11 12:08 |
Merge request merged: https://gitlab.com/openbravo/product/mods/org.openbravo.module.cifnifvalidator/-/merge_requests/1 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2020-08-12 16:48 | shuehner | New Issue | |
| 2020-08-12 16:48 | shuehner | Assigned To | => Jorge Bravo |
| 2020-08-12 16:48 | shuehner | Relationship added | blocks 0044795 |
| 2020-08-14 14:28 | Jorge Bravo | Assigned To | Jorge Bravo => Mery Anelo |
| 2020-08-17 12:36 | shuehner | Note Added: 0122096 | |
| 2020-08-17 12:40 | shuehner | Note Edited: 0122096 | View Revisions |
| 2020-09-05 03:11 | Mery Anelo | Note Added: 0122698 | |
| 2020-09-05 03:11 | Mery Anelo | Status | new => scheduled |
| 2020-09-10 16:42 | hgbot | Note Added: 0122928 | |
| 2020-09-11 12:08 | hgbot | Resolution | open => fixed |
| 2020-09-11 12:08 | hgbot | Status | scheduled => resolved |
| 2020-09-11 12:08 | hgbot | Note Added: 0122956 | |
| 2020-09-11 12:08 | hgbot | Note Added: 0122957 | |
| 2020-09-11 12:08 | hgbot | Note Added: 0122958 | |
| 2020-09-11 12:08 | hgbot | Note Added: 0122959 | |
| 2020-09-11 12:09 | vmromanos | Review Assigned To | => vmromanos |
| 2020-09-11 12:09 | vmromanos | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |