Openbravo Issue Tracking System - Localization Pack: Spain |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0044801 | Localization Pack: Spain | CIF and NIF validator | public | 2020-08-12 16:48 | 2020-09-11 12:09 |
|
| Reporter | shuehner | |
| Assigned To | Mery Anelo | |
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | | |
| Merge Request Status | |
| Regression date | |
| Regression introduced by commit | |
| Regression level | |
| Review Assigned To | vmromanos |
| Support ticket | |
| OBNetwork customer | |
| Regression introduced in release | |
|
| Summary | 0044801: SE_CIFNIF_Validator is an old-style callout and should be refactored to use SimpleCallout |
| Description | This callout is one of the few ones left over not not refactored to be SimpleCallout (issue 36067 refactored every supported module except a few one). |
| Steps To Reproduce | product/mods/org.openbravo.module.cifnifvalidator/src/org/openbravo/module/cifnifvalidator/erpCommon/ad_callouts/SE_CIFNIF_Validator.java: resultado.append("var respuesta = new Array( \n");
|
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | blocks | design defect | 0044795 | | new | Triage Omni OMS | Openbravo ERP | Tracking issue to refactor remaining old callouts to extend SimpleCallout |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2020-08-12 16:48 | shuehner | New Issue | |
| 2020-08-12 16:48 | shuehner | Assigned To | => Jorge Bravo |
| 2020-08-12 16:48 | shuehner | Relationship added | blocks 0044795 |
| 2020-08-14 14:28 | Jorge Bravo | Assigned To | Jorge Bravo => Mery Anelo |
| 2020-08-17 12:36 | shuehner | Note Added: 0122096 | |
| 2020-08-17 12:40 | shuehner | Note Edited: 0122096 | bug_revision_view_page.php?bugnote_id=0122096#r21495 |
| 2020-09-05 03:11 | Mery Anelo | Note Added: 0122698 | |
| 2020-09-05 03:11 | Mery Anelo | Status | new => scheduled |
| 2020-09-10 16:42 | hgbot | Note Added: 0122928 | |
| 2020-09-11 12:08 | hgbot | Resolution | open => fixed |
| 2020-09-11 12:08 | hgbot | Status | scheduled => resolved |
| 2020-09-11 12:08 | hgbot | Note Added: 0122956 | |
| 2020-09-11 12:08 | hgbot | Note Added: 0122957 | |
| 2020-09-11 12:08 | hgbot | Note Added: 0122958 | |
| 2020-09-11 12:08 | hgbot | Note Added: 0122959 | |
| 2020-09-11 12:09 | vmromanos | Review Assigned To | => vmromanos |
| 2020-09-11 12:09 | vmromanos | Status | resolved => closed |
|
Notes |
|
|
(0122096)
|
|
shuehner
|
2020-08-17 12:36
(edited on: 2020-08-17 12:40) |
|
EXECUTE action of callouts is obsolete and does not work for many years. That part of the callout should be reviewed and fixed while working on this also.
Note that this is in codepath trying to support old 2.50 style UI. So probably that could be just removed as no longer required.
|
|
|
|
|
Test plan:
- Login as System Admin
- Manually associated the SE_CIFNIF_Validator callout to the TaxID column of the C_BPartner table.
- Compile the Business Partner window and redeploy the application.
- Login as F&B Internation Group Admin
- Set values to the field "Tax ID" in "Business Partner" windows and check that you have a message when this value is wrong. |
|
|
|
(0122928)
|
|
hgbot
|
|
2020-09-10 16:42
|
|
|
|
|
(0122956)
|
|
hgbot
|
|
2020-09-11 12:08
|
|
|
|
|
(0122957)
|
|
hgbot
|
|
2020-09-11 12:08
|
|
|
|
|
(0122958)
|
|
hgbot
|
|
2020-09-11 12:08
|
|
|
|
|
(0122959)
|
|
hgbot
|
|
2020-09-11 12:08
|
|
|