Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0044596

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Auto BOM For Retail

critical

always

2020-07-10 17:18

2020-08-03 12:48

Reporter

gorkaion

View Status

public

Assigned To

ranjith_qualiantech_com

Priority

immediate

Resolution

fixed

Fixed in Version

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Review Assigned To

adrianromero

Regression level

Production - Confirmed Stable

Regression date

2019-06-05

Regression introduced in release

RR19Q3

Regression introduced by commit

https://code.openbravo.com/erp/pmods/org.openbravo.retail.autobom/rev/f5555db5635c [^]

Triggers an Emergency Pack

No

Summary

0044596: Wrong M_STORAGE_DETAIL table when using AutoBOM with attributes and no stock

Description

Wrong M_STORAGE_DETAIL table when autobom product without stock is sell on POS

As triggers are disabled, the M_STORAGE_DETAIL is not correctly updated

Steps To Reproduce

In the backoffice:
   Go to Veg Burger Product and note the BOM Product list and the available stock.
   Create a new Physical Inventory to:
      Set the current stock of Veg Burger to 0
      Initialize the stock of the BOM Product List (Lettuce, Mozzarella Cheese, Plain Bun and Veg Plain Patty.
   Process the Physical Inventory.
   Go to Veg Burger product definition and set Purchase Lot attribute set.


In the POS:
   Ensure a refresh is done and teh Veg Burger now requires attributes.
   Create a new ticket
   Add Veg Burger product
   Pay it

In the backoffice:
   Go to Product - Transactions tab and check two transactions have been created there: a positive one related with the bill of materials production and a negative one related with the goods shipment

   Go to Product - Stock tab and check the Quantity On Hand is -1 and it should be 0

Proposed Solution

This is the same issue reported in 0039921 whose fix was lost on Restaurants project merge.

Please note that original fix was not correct. In case of having an AutoBOM product with NO attributes the triggers are not disabled so the SD was updated twice leaving a stock of 0 but a Quantity On Hand of +1.

Ideally fixes of issues 0038687 and 0039120 should be reviewed to avoid disabling the triggers so the SD is correctly updated.

Tags

No tags attached.

Relationships [ Relation Graph ] [ Dependency Graph ]

related to	defect	0039921		closed	jorge-garcia	Retail Modules	Wrong M_STORAGE_DETAIL table if 'support for attributes' is set to N and a autobom product without stock is sell on POS
depends on	defect	0044622		closed	inigo_lerga	Openbravo ERP	Attribute required check in M_TRANSACTION_TRG trigger should be relaxed
caused by	defect	0038687		closed	rqueralta	Retail Modules	Autobom not working wth products that have attributes and if there is not stock.
caused by	defect	0039120		closed	rqueralta	Retail Modules	Order goes to Errors While Importing POS Data if the product is Auto Generate BOM and has a mandatory Attribute Set assigned

Notes
(0121759) hgbot (developer) 2020-08-03 12:45	Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.autobom [^] Changeset: eaa539fd3afae31ef3f373e8b798d8605982d7aa Author: Ranjith S R <ranjith@qualiantech.com> Date: 2020-07-17T11:11:59+05:30 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.autobom/-/commit/eaa539fd3afae31ef3f373e8b798d8605982d7aa [^] Related to issue-44596: Transactions should be created with attributeSet for autoBom product * Material Transaction and Production Line should be created with lines attributeSet if exists * Removed Trigger validation for transaction creation --- M src/org/openbravo/retail/autobom/process/BOMProcess.java ---

(0121760) adrianromero (manager) 2020-08-03 12:48	Merge Request: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.autobom/-/merge_requests/2 [^]

(0121761) adrianromero (manager) 2020-08-03 12:48	Verified

Issue History
Date Modified	Username	Field	Change
2020-07-10 17:18	gorkaion	New Issue
2020-07-10 17:18	gorkaion	Assigned To	=> Retail
2020-07-10 17:18	gorkaion	Resolution time	=> 1596146400
2020-07-10 17:18	gorkaion	Regression level	=> Production - Confirmed Stable
2020-07-10 17:18	gorkaion	Regression date	=> 2019-06-05
2020-07-10 17:18	gorkaion	Regression introduced in release	=> RR19Q3
2020-07-10 17:18	gorkaion	Regression introduced by commit	=> https://code.openbravo.com/erp/pmods/org.openbravo.retail.autobom/rev/f5555db5635c [^]
2020-07-10 17:18	gorkaion	Triggers an Emergency Pack	=> No
2020-07-10 17:18	gorkaion	Issue generated from	0039921
2020-07-10 17:18	gorkaion	Relationship added	related to 0039921
2020-07-10 17:18	gorkaion	Relationship added	caused by 0038687
2020-07-10 17:18	gorkaion	Relationship added	caused by 0039120
2020-07-14 08:08	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2020-07-16 14:24	gorkaion	Relationship added	depends on 0044622
2020-07-20 12:21	ngarcia	Issue Monitored: ngarcia
2020-08-03 12:45	hgbot	Note Added: 0121759
2020-08-03 12:47	adrianromero	Status	new => scheduled
2020-08-03 12:47	adrianromero	Status	scheduled => resolved
2020-08-03 12:47	adrianromero	Resolution	open => fixed
2020-08-03 12:48	adrianromero	Note Added: 0121760
2020-08-03 12:48	adrianromero	Review Assigned To	=> adrianromero
2020-08-03 12:48	adrianromero	Note Added: 0121761
2020-08-03 12:48	adrianromero	Status	resolved => closed

Copyright © 2000 - 2009 MantisBT Group