Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044596Retail ModulesAuto BOM For Retailpublic2020-07-10 17:182020-08-03 12:48
Reportergorkaion 
Assigned Toranjith_qualiantech_com 
PriorityimmediateSeveritycriticalReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Toadrianromero
OBNetwork customer
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2019-06-05
Regression introduced in releaseRR19Q3
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.autobom/rev/f5555db5635c [^]
Triggers an Emergency PackNo
Summary0044596: Wrong M_STORAGE_DETAIL table when using AutoBOM with attributes and no stock
DescriptionWrong M_STORAGE_DETAIL table when autobom product without stock is sell on POS

As triggers are disabled, the M_STORAGE_DETAIL is not correctly updated
Steps To ReproduceIn the backoffice:
   Go to Veg Burger Product and note the BOM Product list and the available stock.
   Create a new Physical Inventory to:
      Set the current stock of Veg Burger to 0
      Initialize the stock of the BOM Product List (Lettuce, Mozzarella Cheese, Plain Bun and Veg Plain Patty.
   Process the Physical Inventory.
   Go to Veg Burger product definition and set Purchase Lot attribute set.
   

In the POS:
   Ensure a refresh is done and teh Veg Burger now requires attributes.
   Create a new ticket
   Add Veg Burger product
   Pay it

In the backoffice:
   Go to Product - Transactions tab and check two transactions have been created there: a positive one related with the bill of materials production and a negative one related with the goods shipment

   Go to Product - Stock tab and check the Quantity On Hand is -1 and it should be 0
Proposed SolutionThis is the same issue reported in 0039921 whose fix was lost on Restaurants project merge.

Please note that original fix was not correct. In case of having an AutoBOM product with NO attributes the triggers are not disabled so the SD was updated twice leaving a stock of 0 but a Quantity On Hand of +1.

Ideally fixes of issues 0038687 and 0039120 should be reviewed to avoid disabling the triggers so the SD is correctly updated.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0039921 closed jorge-garcia Retail Modules Wrong M_STORAGE_DETAIL table if 'support for attributes' is set to N and a autobom product without stock is sell on POS 
depends on defect 0044622 closed inigo_lerga Openbravo ERP Attribute required check in M_TRANSACTION_TRG trigger should be relaxed 
caused by defect 0038687 closed rqueralta Retail Modules Autobom not working wth products that have attributes and if there is not stock. 
caused by defect 0039120 closed rqueralta Retail Modules Order goes to Errors While Importing POS Data if the product is Auto Generate BOM and has a mandatory Attribute Set assigned 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-07-10 17:18gorkaionNew Issue
2020-07-10 17:18gorkaionAssigned To => Retail
2020-07-10 17:18gorkaionResolution time => 1596146400
2020-07-10 17:18gorkaionRegression level => Production - Confirmed Stable
2020-07-10 17:18gorkaionRegression date => 2019-06-05
2020-07-10 17:18gorkaionRegression introduced in release => RR19Q3
2020-07-10 17:18gorkaionRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.autobom/rev/f5555db5635c [^]
2020-07-10 17:18gorkaionTriggers an Emergency Pack => No
2020-07-10 17:18gorkaionIssue generated from0039921
2020-07-10 17:18gorkaionRelationship addedrelated to 0039921
2020-07-10 17:18gorkaionRelationship addedcaused by 0038687
2020-07-10 17:18gorkaionRelationship addedcaused by 0039120
2020-07-14 08:08ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2020-07-16 14:24gorkaionRelationship addeddepends on 0044622
2020-07-20 12:21ngarciaIssue Monitored: ngarcia
2020-08-03 12:45hgbotNote Added: 0121759
2020-08-03 12:47adrianromeroStatusnew => scheduled
2020-08-03 12:47adrianromeroStatusscheduled => resolved
2020-08-03 12:47adrianromeroResolutionopen => fixed
2020-08-03 12:48adrianromeroNote Added: 0121760
2020-08-03 12:48adrianromeroReview Assigned To => adrianromero
2020-08-03 12:48adrianromeroNote Added: 0121761
2020-08-03 12:48adrianromeroStatusresolved => closed

Notes
(0121759)
hgbot   
2020-08-03 12:45   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.autobom [^]
Changeset: eaa539fd3afae31ef3f373e8b798d8605982d7aa
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-07-17T11:11:59+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.autobom/-/commit/eaa539fd3afae31ef3f373e8b798d8605982d7aa [^]

Related to issue-44596: Transactions should be created with attributeSet for autoBom product
* Material Transaction and Production Line should be created with lines attributeSet if exists
* Removed Trigger validation for transaction creation

---
M src/org/openbravo/retail/autobom/process/BOMProcess.java
---
(0121760)
adrianromero   
2020-08-03 12:48   
Merge Request: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.autobom/-/merge_requests/2 [^]
(0121761)
adrianromero   
2020-08-03 12:48   
Verified