Anonymous | Login
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Openbravo ERP] A. Platformminoralways2008-07-17 16:582022-02-01 08:08
ReporterjordimasView Statuspublic 
Assigned ToTriage Platform Base 
PrioritynormalResolutionopenFixed in Version
StatusacknowledgedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned To
Web browser
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo

0004446: Review list of allowed characters in Tab/Window-names and normalization for internal use (i.e. FormatUtilities.replaceTildes)


The FormatUtilities class contains the following code:

  public static String replaceTildes(String strIni) {
    //Delete tilde characters
    return strIni.replace('á', 'a').replace('é', 'e').replace('í', 'i').replace('ó', 'o').replace('ú', 'u').replace('Á', 'A').replace('É', 'E').replace('Í', 'I').replace('Ó', 'O').replace('Ú', 'U');

Which from an internationalization point of view is most likely wrong.

Proposed SolutionSuggested actions:

· Someone reviews the code and understands why is used
· Deletes the members or replaces it by a I18N friendly code
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
depends on backport 0004893 closedshuehner Request to review FormatUtilities.replaceTildes 
blocks feature request 0007236 acknowledgedshuehner Tracking issue: Cleanup for 3.00 

-  Notes
shuehner (administrator)
2008-07-22 15:52

This function is only used via FormatUtilities.replace.

This one has as lot of user. A quick grep through these show that it is mainly used for normalizing filenames and urls. So not directly user visible labels.

If we want to change it, we have to audit each user where the files which are referenced are generated and have to change these as well.
shuehner (administrator)
2009-01-21 13:24

This could manifest itself as a bug when i.e. a tab of a window is defined with a name containing a special character not in the list which is specified in the replaceTildes method. Then we would create the link for i.e. Button still containing this special characters which is not correct and will not work.
shuehner (administrator)
2009-01-30 14:42

Change to feature request as we dont have a specific defect right now because of this code.

Instead we should check and synchronize all methods which translate Tab-/Window-names into i.e. urls or java package- and/or classnames.

This then will include this methods and at least another database trigger doing the same on db-level.

- Issue History
Date Modified Username Field Change
2008-07-17 16:58 jordimas New Issue
2008-07-17 16:58 jordimas Assigned To => cromero
2008-07-17 16:58 jordimas sf_bug_id 0 => 2020686
2008-07-17 16:58 jordimas Issue Monitored: jordimas
2008-07-22 10:54 cromero Status new => scheduled
2008-07-22 10:54 cromero Assigned To cromero => shuehner
2008-07-22 10:54 cromero fix_in_branch => trunk
2008-07-22 15:52 shuehner Note Added: 0008372
2009-01-21 13:24 shuehner Note Added: 0012452
2009-01-30 14:42 shuehner Note Added: 0012905
2009-01-30 14:42 shuehner Type defect => feature request
2009-01-30 14:42 shuehner fix_in_branch trunk =>
2009-01-30 14:42 shuehner Summary Request to review FormatUtilities.replaceTildes => Review list of allowed characters in Tab/Window-names and normalization for internal use (i.e. FormatUtilities.replaceTildes)
2009-01-30 14:42 shuehner Relationship added blocks 0007236
2009-01-30 14:43 shuehner Status scheduled => acknowledged
2012-02-20 11:42 shuehner Assigned To shuehner => alostale
2017-04-10 14:37 alostale Assigned To alostale => platform
2022-02-01 08:08 alostale Assigned To platform => Triage Platform Base

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker