Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0004446Openbravo ERPA. Platformpublic2008-07-17 16:582022-02-01 08:08
Reporterjordimas 
Assigned ToTriage Platform Base 
PrioritynormalSeverityminorReproducibilityalways
StatusacknowledgedResolutionopen 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0004446: Review list of allowed characters in Tab/Window-names and normalization for internal use (i.e. FormatUtilities.replaceTildes)
DescriptionHello,

The FormatUtilities class contains the following code:

  public static String replaceTildes(String strIni) {
    //Delete tilde characters
    return strIni.replace('á', 'a').replace('é', 'e').replace('í', 'i').replace('ó', 'o').replace('ú', 'u').replace('Á', 'A').replace('É', 'E').replace('Í', 'I').replace('Ó', 'O').replace('Ú', 'U');
  }

Which from an internationalization point of view is most likely wrong.

Steps To Reproduce
Proposed SolutionSuggested actions:

· Someone reviews the code and understands why is used
· Deletes the members or replaces it by a I18N friendly code
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0004893 closed shuehner Request to review FormatUtilities.replaceTildes 
blocks feature request 0007236 acknowledged shuehner Tracking issue: Cleanup for 3.00 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2008-07-17 16:58jordimasNew Issue
2008-07-17 16:58jordimasAssigned To => cromero
2008-07-17 16:58jordimassf_bug_id0 => 2020686
2008-07-17 16:58jordimasOBNetwork customer => No
2008-07-17 16:58jordimasIssue Monitored: jordimas
2008-07-22 10:54cromeroStatusnew => scheduled
2008-07-22 10:54cromeroAssigned Tocromero => shuehner
2008-07-22 10:54cromerofix_in_branch => trunk
2008-07-22 15:52shuehnerNote Added: 0008372
2009-01-21 13:24shuehnerNote Added: 0012452
2009-01-30 14:42shuehnerNote Added: 0012905
2009-01-30 14:42shuehnerTypedefect => feature request
2009-01-30 14:42shuehnerfix_in_branchtrunk =>
2009-01-30 14:42shuehnerSummaryRequest to review FormatUtilities.replaceTildes => Review list of allowed characters in Tab/Window-names and normalization for internal use (i.e. FormatUtilities.replaceTildes)
2009-01-30 14:42shuehnerRelationship addedblocks 0007236
2009-01-30 14:43shuehnerStatusscheduled => acknowledged
2012-02-20 11:42shuehnerAssigned Toshuehner => alostale
2017-04-10 14:37alostaleAssigned Toalostale => platform
2022-02-01 08:08alostaleAssigned Toplatform => Triage Platform Base

Notes
(0008372)
shuehner   
2008-07-22 15:52   
This function is only used via FormatUtilities.replace.

This one has as lot of user. A quick grep through these show that it is mainly used for normalizing filenames and urls. So not directly user visible labels.

If we want to change it, we have to audit each user where the files which are referenced are generated and have to change these as well.
(0012452)
shuehner   
2009-01-21 13:24   
This could manifest itself as a bug when i.e. a tab of a window is defined with a name containing a special character not in the list which is specified in the replaceTildes method. Then we would create the link for i.e. Button still containing this special characters which is not correct and will not work.
(0012905)
shuehner   
2009-01-30 14:42   
Change to feature request as we dont have a specific defect right now because of this code.

Instead we should check and synchronize all methods which translate Tab-/Window-names into i.e. urls or java package- and/or classnames.

This then will include this methods and at least another database trigger doing the same on db-level.