0044435: Editing customer and save creates duplicate loyalty subscription

# HG changeset patch
# User Prakash M <prakash@qualiantech.com>
# Date 1592825081 -19800
#      Mon Jun 22 16:54:41 2020 +0530
# Node ID 0f53803f200ad8e03d6a03fbe4aa971581c4a1dc
# Parent  8106465681e1f1a4d0f339f4f07a2d6da0dc3210
Related to BUG-44435: Editing customer and save creates duplicate loyalty subscription
* This is because on opening a new customer popup it sets Automatic Membership
Programs to the new customer.
* Therefore Automatic Membership Programs are subscribed by default on saving
the new customer.
* However it works similarly for edit customer popup, But it should not.
* It should skip loyalty programs already subscribed by the selected customer.

* Fix - In case of edit customer, automatic loyalty programs that are not
subscribed by customer are created.

diff -r 8106465681e1 -r 0f53803f200a web/org.openbravo.retail.loyalty.programs/js/view/customeredit-fields.js
--- a/web/org.openbravo.retail.loyalty.programs/js/view/customeredit-fields.js	Sat Apr 18 11:17:12 2020 +0530
+++ b/web/org.openbravo.retail.loyalty.programs/js/view/customeredit-fields.js	Mon Jun 22 16:54:41 2020 +0530
@@ -85,13 +85,88 @@
           comp.setShowing(OB.UTIL.isNullOrUndefined(me.args.businessPartner));
         };
 
-        var programsWithAutomaticMembership = OBRLP.Util.getLoyaltyProgramsWithAutomaticMembership();
-        _.forEach(programsWithAutomaticMembership, function(program) {
-          createProgramFields(program);
-        });
+        const createUnsubscribedAutoLoyaltyProgramFields = function(
+          programsSubscribedByBP
+        ) {
+          const programsWithAutomaticMembership = OBRLP.Util.getLoyaltyProgramsWithAutomaticMembership();
+          let programsToBeSubscribed = [];
+
+          if (programsSubscribedByBP && programsSubscribedByBP.length > 0) {
+            _.forEach(programsWithAutomaticMembership, function(autoProgram) {
+              const subscribed = programsSubscribedByBP.find(function(subs) {
+                return subs.get('programId') === autoProgram.id;
+              });
+              if (!subscribed) {
+                programsToBeSubscribed.push(autoProgram);
+              }
+            });
+          } else {
+            programsToBeSubscribed = programsWithAutomaticMembership;
+          }
+
+          _.forEach(programsToBeSubscribed, function(program) {
+            createProgramFields(program);
+          });
+
+          me.automaticFieldsCreated = true;
+          return ret;
+        };
+
+        const errorCallback = function(error) {
+          OB.error(
+            'Error getting loyalty Programs Subscribed By Customer ' +
+              me.args.businessPartner.id
+          );
+          createUnsubscribedAutoLoyaltyProgramFields();
+        };
 
-        me.automaticFieldsCreated = true;
-        return ret;
+        const getLoyaltySubscribedByBP = function(
+          customer,
+          successCallback,
+          errorCallback
+        ) {
+          const isRemoteForCustomer = OB.MobileApp.model.hasPermission(
+            'OBPOS_remote.customer',
+            true
+          );
+
+          const criteria = {
+            customerId: customer.id
+          };
+
+          if (isRemoteForCustomer) {
+            criteria.remoteFilters = [
+              {
+                columns: ['customerId'],
+                operator: OB.Dal.EQ,
+                value: customer.id,
+                isId: true
+              }
+            ];
+          }
+
+          OB.Dal.find(
+            OB.Model.OBRLP_LoyaltySubscriptions,
+            criteria,
+            function(results) {
+              successCallback(results);
+            },
+            function(e) {
+              errorCallback(e);
+              return;
+            }
+          );
+        };
+
+        if (me.args.businessPartner != null) {
+          getLoyaltySubscribedByBP(
+            me.args.businessPartner,
+            createUnsubscribedAutoLoyaltyProgramFields,
+            errorCallback
+          );
+        } else {
+          createUnsubscribedAutoLoyaltyProgramFields();
+        }
       }
     };
   })();