Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044435Retail ModulesLoyalty Management for Retailpublic2020-06-20 16:102020-06-22 13:27
Reporterprakashmurugesan88 
Assigned Toprakashmurugesan88 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0044435: Editing customer and save creates duplicate loyalty subscription
DescriptionOn trying to edit a customer with loyalty subscription(Automatic Membership flag checked) and save, creates duplicate loyalty subscription in WEBPOS.

This is because on opening a new customer popup it sets Automatic Membership Programs to the new customer.
Therefore Automatic Membership Programs are subscribed by default on saving the new customer.

However it works similarly for edit customer popup.
But it should not.
It should skip loyalty programs already subscribed by the selected customer.
Steps To ReproduceCheck following video

https://drive.google.com/file/d/1HCmp5CdWPDcq3diU3CqMtTKJvEauPmVt/view?usp=sharing [^]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespatch I44435_20Q2.patch (4,124) 2020-06-22 13:27
https://issues.openbravo.com/file_download.php?file_id=14669&type=bug
Issue History
Date ModifiedUsernameFieldChange
2020-06-20 16:10prakashmurugesan88New Issue
2020-06-20 16:10prakashmurugesan88Assigned To => prakashmurugesan88
2020-06-20 16:10prakashmurugesan88OBNetwork customer => No
2020-06-20 16:10prakashmurugesan88Triggers an Emergency Pack => No
2020-06-20 16:11prakashmurugesan88Statusnew => scheduled
2020-06-22 12:01hgbotCheckin
2020-06-22 12:02hgbotNote Added: 0120954
2020-06-22 12:02hgbotStatusscheduled => resolved
2020-06-22 12:02hgbotResolutionopen => fixed
2020-06-22 12:02hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.loyalty.programs/rev/a0bc1b45bbbdbdf75dce1882c4bbfd3d42b880c3 [^]
2020-06-22 12:12marvintmReview Assigned To => marvintm
2020-06-22 12:12marvintmStatusresolved => closed
2020-06-22 12:12marvintmFixed in Version => RR20Q3
2020-06-22 13:27prakashmurugesan88File Added: I44435_20Q2.patch

Notes
(0120954)
hgbot   
2020-06-22 12:01   
Repository: erp/pmods/org.openbravo.retail.loyalty.programs
Changeset: a0bc1b45bbbdbdf75dce1882c4bbfd3d42b880c3
Author: prakash-1040 <prakash <at> qualiantech.com>
Date: Sat Jun 20 20:02:21 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.loyalty.programs/rev/a0bc1b45bbbdbdf75dce1882c4bbfd3d42b880c3 [^]

Fixed BUG-44435: Editing customer and save creates duplicate loyalty
subscription

* This is because on opening a new customer popup it sets Automatic Membership
Programs to the new customer.
* Therefore Automatic Membership Programs are subscribed by default on saving
the new customer.
* However it works similarly for edit customer popup, But it should not.
* It should skip loyalty programs already subscribed by the selected customer.

* Fix - In case of edit customer, automatic loyalty programs that are not
subscribed by customer are created.

---
M web/org.openbravo.retail.loyalty.programs/js/view/customeredit-fields.js
---