Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0044356
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Advanced Warehouse Operationsminorhave not tried2020-06-12 12:442020-08-12 14:46
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Regression introduced in release
Summary

0044356: Apply new HQL Style in CheckRoutingWithoutITT.java

DescriptionCheckRoutingWithoutITT.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to design defect 0041287 acknowledgedTriage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 

-  Notes
(0120824)
inigo_lerga (reporter)
2020-06-12 12:54
edited on: 2020-06-12 12:54

--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.

As the AWO-QA-Admin - AWO-QA role in Backend:
- Go to Warehouse Configuration Check window,
  select US Organization and press Done button.

#In this moment the modified HQL is executed#

(0122007)
hgbot (developer)
2020-08-12 14:42

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/merge_requests/2 [^]
(0122008)
hgbot (developer)
2020-08-12 14:43

Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/merge_requests/2 [^]
(0122009)
hgbot (developer)
2020-08-12 14:45

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/merge_requests/3 [^]
(0122010)
hgbot (developer)
2020-08-12 14:45

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations [^]
Changeset: 2e2712cfa875050e3a60d58048b394cb6c97ad93
Author: david.miguelez <david.miguelez@openbravo.com>
Date: 2020-08-12T14:44:39+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/commit/2e2712cfa875050e3a60d58048b394cb6c97ad93 [^]

fixes BUG-44356:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/warehouseconfigurationcheck/implementation/CheckRoutingWithoutITT.java
---
(0122011)
hgbot (developer)
2020-08-12 14:45

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/merge_requests/3 [^]
(0122012)
dmiguelez (developer)
2020-08-12 14:46

Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-06-12 12:44 inigo_lerga New Issue
2020-06-12 12:44 inigo_lerga Assigned To => inigo_lerga
2020-06-12 12:44 inigo_lerga Status new => scheduled
2020-06-12 12:44 inigo_lerga Relationship added related to 0041287
2020-06-12 12:54 inigo_lerga Note Added: 0120824
2020-06-12 12:54 inigo_lerga Note Edited: 0120824 View Revisions
2020-08-12 14:42 hgbot Note Added: 0122007
2020-08-12 14:43 hgbot Note Added: 0122008
2020-08-12 14:45 hgbot Note Added: 0122009
2020-08-12 14:45 hgbot Resolution open => fixed
2020-08-12 14:45 hgbot Status scheduled => resolved
2020-08-12 14:45 hgbot Note Added: 0122010
2020-08-12 14:45 hgbot Note Added: 0122011
2020-08-12 14:46 dmiguelez Review Assigned To => dmiguelez
2020-08-12 14:46 dmiguelez Note Added: 0122012
2020-08-12 14:46 dmiguelez Status resolved => closed
2022-09-06 17:18 caristu Category Advance Warehouse Operations => Advanced Warehouse Operations


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker