Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044356ModulesAdvanced Warehouse Operationspublic2020-06-12 12:442020-08-12 14:46
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusmerged
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customerNo
Regression introduced in release
Summary0044356: Apply new HQL Style in CheckRoutingWithoutITT.java
DescriptionCheckRoutingWithoutITT.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-06-12 12:44inigo_lergaNew Issue
2020-06-12 12:44inigo_lergaAssigned To => inigo_lerga
2020-06-12 12:44inigo_lergaOBNetwork customer => No
2020-06-12 12:44inigo_lergaStatusnew => scheduled
2020-06-12 12:44inigo_lergaRelationship addedrelated to 0041287
2020-06-12 12:54inigo_lergaNote Added: 0120824
2020-06-12 12:54inigo_lergaNote Edited: 0120824bug_revision_view_page.php?bugnote_id=0120824#r21187
2020-08-12 14:42hgbotMerge Request Status => open
2020-08-12 14:42hgbotNote Added: 0122007
2020-08-12 14:43hgbotNote Added: 0122008
2020-08-12 14:45hgbotNote Added: 0122009
2020-08-12 14:45hgbotResolutionopen => fixed
2020-08-12 14:45hgbotStatusscheduled => resolved
2020-08-12 14:45hgbotNote Added: 0122010
2020-08-12 14:45hgbotMerge Request Statusopen => merged
2020-08-12 14:45hgbotNote Added: 0122011
2020-08-12 14:46dmiguelezReview Assigned To => dmiguelez
2020-08-12 14:46dmiguelezNote Added: 0122012
2020-08-12 14:46dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0120824)
inigo_lerga   
2020-06-12 12:54   
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.

As the AWO-QA-Admin - AWO-QA role in Backend:
- Go to Warehouse Configuration Check window,
  select US Organization and press Done button.

#In this moment the modified HQL is executed#
(0122007)
hgbot   
2020-08-12 14:42   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/merge_requests/2 [^]
(0122008)
hgbot   
2020-08-12 14:43   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/merge_requests/2 [^]
(0122009)
hgbot   
2020-08-12 14:45   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/merge_requests/3 [^]
(0122010)
hgbot   
2020-08-12 14:45   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations [^]
Changeset: 2e2712cfa875050e3a60d58048b394cb6c97ad93
Author: david.miguelez <david.miguelez@openbravo.com>
Date: 2020-08-12T14:44:39+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/commit/2e2712cfa875050e3a60d58048b394cb6c97ad93 [^]

fixes BUG-44356:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/warehouseconfigurationcheck/implementation/CheckRoutingWithoutITT.java
---
(0122011)
hgbot   
2020-08-12 14:45   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/merge_requests/3 [^]
(0122012)
dmiguelez   
2020-08-12 14:46   
Code Review + Testing Ok