Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0044290 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | major | always | 2020-06-05 08:21 | 2020-06-24 11:18 | |||
| Reporter | marvintm | View Status | public | |||||
| Assigned To | prakashmurugesan88 | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RR20Q3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | c845585d599a | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | marvintm | |||||||
| OBNetwork customer | No | |||||||
| Support ticket | ||||||||
| Regression level | Pre packaging ( pi ) | |||||||
| Regression date | 2020-04-17 | |||||||
| Regression introduced in release | pi | |||||||
| Regression introduced by commit | https://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.coupons/rev/f4e367b41b87#l2.21 [^] | |||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0044290: Coupons are not linked to the discount in the order when used | |||||||
| Description | Coupons are supposed to be linked to the discount line in the order when used. However, this is currently not happening. | |||||||
| Steps To Reproduce | Define a coupon related to a discount. Go to the WebPOS create a ticket which can get this discount. Add the coupon. Verify that the discount appears in the ticket. Complete the ticket. Go to the backend, to the Sales Order window, navigate to the line that received the discount, and then go to the Discounts and Promotions subtab of this window. Realise that the discount is there, but it is not linked to the coupon. | |||||||
| Proposed Solution | The OrderLoaderCouponsHook class is not taking the coupon datamodel correctly into account. | |||||||
| Tags | NOR | |||||||
| Attached Files |  image_2020_06_04T22_35_22_615Z.png [^] (20,792 bytes) 2020-06-05 08:22
image_2020_06_04T22_36_19_761Z.png [^] (30,923 bytes) 2020-06-05 08:22
image_2020_06_04T22_37_13_636Z.png [^] (38,598 bytes) 2020-06-05 08:22
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0120709) hgbot (developer) 2020-06-05 13:35 |
Repository: erp/pmods/org.openbravo.retail.discounts.coupons Changeset: 0cfbde1bb515b4b4e0ece8fda02669e754437e45 Author: Prakash M <prakash <at> qualiantech.com> Date: Fri Jun 05 17:02:52 2020 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.coupons/rev/0cfbde1bb515b4b4e0ece8fda02669e754437e45 [^] Related to BUG-44290: Coupons are not linked to the discount in the order when used * This is because coupon details structure in jsonorder is changed * Coupons are placed inside discountsFromUser object. * So fixed by fetching coupons from discountsFromUser object in jsonorder --- M src/org/openbravo/retail/discounts/coupons/OrderLoaderHookCoupons.java --- |
|
(0120717) hgbot (developer) 2020-06-06 07:29 |
Repository: tools/automation/pi-mobile Changeset: ba4f6da445e13b6d4eddc34108dcfc760008bbfe Author: Prakash M <prakash <at> qualiantech.com> Date: Sat Jun 06 10:58:07 2020 +0530 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/ba4f6da445e13b6d4eddc34108dcfc760008bbfe [^] Related to BUG-44290: Included coupon code verification in CheckCouponsDiscounts test --- M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_coupons/CheckCouponsDiscounts.java --- |
|
(0121008) marvintm (viewer) 2020-06-24 08:19 |
The same problem also happens here: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/blob/master/src/org/openbravo/retail/discounts/coupons/PreOrderLoaderHookCoupons.java [^] |
|
(0121014) hgbot (developer) 2020-06-24 10:35 |
Repository: erp/pmods/org.openbravo.retail.discounts.coupons Changeset: c845585d599a80c10089dfdb717e0d4856819cb9 Author: Prakash M <prakash <at> qualiantech.com> Date: Wed Jun 24 14:04:54 2020 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.coupons/rev/c845585d599a80c10089dfdb717e0d4856819cb9 [^] Fixed BUG-44290: Coupons are not linked to the discount in the order when used * This is because coupon details structure in jsonorder is changed * Coupons are placed inside discountsFromUser object. * So fixed by fetching coupons from discountsFromUser object in jsonorder * Fixed in PreOrderLoaderHookCoupons as well --- M src/org/openbravo/retail/discounts/coupons/PreOrderLoaderHookCoupons.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2020-06-05 08:21 | marvintm | New Issue | |
| 2020-06-05 08:21 | marvintm | Assigned To | => Retail |
| 2020-06-05 08:21 | marvintm | OBNetwork customer | => No |
| 2020-06-05 08:21 | marvintm | Triggers an Emergency Pack | => No |
| 2020-06-05 08:22 | marvintm | File Added: image_2020_06_04T22_35_22_615Z.png | |
| 2020-06-05 08:22 | marvintm | File Added: image_2020_06_04T22_36_19_761Z.png | |
| 2020-06-05 08:22 | marvintm | File Added: image_2020_06_04T22_37_13_636Z.png | |
| 2020-06-05 08:25 | prakashmurugesan88 | Assigned To | Retail => prakashmurugesan88 |
| 2020-06-05 08:25 | prakashmurugesan88 | Status | new => scheduled |
| 2020-06-05 10:53 | marvintm | Regression level | => Pre packaging ( pi ) |
| 2020-06-05 10:53 | marvintm | Regression date | => 2020-04-17 |
| 2020-06-05 10:53 | marvintm | Regression introduced in release | => pi |
| 2020-06-05 10:53 | marvintm | Regression introduced by commit | => https://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.coupons/rev/f4e367b41b87#l2.21 [^] |
| 2020-06-05 13:35 | hgbot | Checkin | |
| 2020-06-05 13:35 | hgbot | Note Added: 0120709 | |
| 2020-06-06 07:29 | hgbot | Checkin | |
| 2020-06-06 07:29 | hgbot | Note Added: 0120717 | |
| 2020-06-06 07:30 | prakashmurugesan88 | Status | scheduled => resolved |
| 2020-06-06 07:30 | prakashmurugesan88 | Resolution | open => fixed |
| 2020-06-08 06:28 | rafaroda | Tag Attached: NOR | |
| 2020-06-12 16:19 | marvintm | Review Assigned To | => marvintm |
| 2020-06-12 16:19 | marvintm | Status | resolved => closed |
| 2020-06-12 16:19 | marvintm | Fixed in Version | => RR20Q3 |
| 2020-06-24 08:19 | marvintm | Note Added: 0121008 | |
| 2020-06-24 08:19 | marvintm | Status | closed => new |
| 2020-06-24 08:19 | marvintm | Resolution | fixed => open |
| 2020-06-24 08:19 | marvintm | Fixed in Version | RR20Q3 => |
| 2020-06-24 10:35 | hgbot | Checkin | |
| 2020-06-24 10:35 | hgbot | Note Added: 0121014 | |
| 2020-06-24 10:35 | hgbot | Status | new => resolved |
| 2020-06-24 10:35 | hgbot | Resolution | open => fixed |
| 2020-06-24 10:35 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.coupons/rev/c845585d599a80c10089dfdb717e0d4856819cb9 [^] |
| 2020-06-24 11:18 | marvintm | Status | resolved => closed |
| 2020-06-24 11:18 | marvintm | Fixed in Version | => RR20Q3 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |