Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044290Retail ModulesWeb POSpublic2020-06-05 08:212020-06-24 11:18
Reportermarvintm 
Assigned Toprakashmurugesan88 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression levelPre packaging ( pi )
Regression date2020-04-17
Regression introduced in releasepi
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.coupons/rev/f4e367b41b87#l2.21 [^]
Triggers an Emergency PackNo
Summary0044290: Coupons are not linked to the discount in the order when used
DescriptionCoupons are supposed to be linked to the discount line in the order when used. However, this is currently not happening.
Steps To ReproduceDefine a coupon related to a discount.
Go to the WebPOS create a ticket which can get this discount. Add the coupon. Verify that the discount appears in the ticket.
Complete the ticket.
Go to the backend, to the Sales Order window, navigate to the line that received the discount, and then go to the Discounts and Promotions subtab of this window. Realise that the discount is there, but it is not linked to the coupon.
Proposed SolutionThe OrderLoaderCouponsHook class is not taking the coupon datamodel correctly into account.
Additional Information
TagsNOR
Relationships
Attached Filespng image_2020_06_04T22_35_22_615Z.png (20,792) 2020-06-05 08:22
https://issues.openbravo.com/file_download.php?file_id=14575&type=bug
png

png image_2020_06_04T22_36_19_761Z.png (30,923) 2020-06-05 08:22
https://issues.openbravo.com/file_download.php?file_id=14576&type=bug
png

png image_2020_06_04T22_37_13_636Z.png (38,598) 2020-06-05 08:22
https://issues.openbravo.com/file_download.php?file_id=14577&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2020-06-05 08:21marvintmNew Issue
2020-06-05 08:21marvintmAssigned To => Retail
2020-06-05 08:21marvintmOBNetwork customer => No
2020-06-05 08:21marvintmTriggers an Emergency Pack => No
2020-06-05 08:22marvintmFile Added: image_2020_06_04T22_35_22_615Z.png
2020-06-05 08:22marvintmFile Added: image_2020_06_04T22_36_19_761Z.png
2020-06-05 08:22marvintmFile Added: image_2020_06_04T22_37_13_636Z.png
2020-06-05 08:25prakashmurugesan88Assigned ToRetail => prakashmurugesan88
2020-06-05 08:25prakashmurugesan88Statusnew => scheduled
2020-06-05 10:53marvintmRegression level => Pre packaging ( pi )
2020-06-05 10:53marvintmRegression date => 2020-04-17
2020-06-05 10:53marvintmRegression introduced in release => pi
2020-06-05 10:53marvintmRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.coupons/rev/f4e367b41b87#l2.21 [^]
2020-06-05 13:35hgbotCheckin
2020-06-05 13:35hgbotNote Added: 0120709
2020-06-06 07:29hgbotCheckin
2020-06-06 07:29hgbotNote Added: 0120717
2020-06-06 07:30prakashmurugesan88Statusscheduled => resolved
2020-06-06 07:30prakashmurugesan88Resolutionopen => fixed
2020-06-08 06:28rafarodaTag Attached: NOR
2020-06-12 16:19marvintmReview Assigned To => marvintm
2020-06-12 16:19marvintmStatusresolved => closed
2020-06-12 16:19marvintmFixed in Version => RR20Q3
2020-06-24 08:19marvintmNote Added: 0121008
2020-06-24 08:19marvintmStatusclosed => new
2020-06-24 08:19marvintmResolutionfixed => open
2020-06-24 08:19marvintmFixed in VersionRR20Q3 =>
2020-06-24 10:35hgbotCheckin
2020-06-24 10:35hgbotNote Added: 0121014
2020-06-24 10:35hgbotStatusnew => resolved
2020-06-24 10:35hgbotResolutionopen => fixed
2020-06-24 10:35hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.coupons/rev/c845585d599a80c10089dfdb717e0d4856819cb9 [^]
2020-06-24 11:18marvintmStatusresolved => closed
2020-06-24 11:18marvintmFixed in Version => RR20Q3

Notes
(0120709)
hgbot   
2020-06-05 13:35   
Repository: erp/pmods/org.openbravo.retail.discounts.coupons
Changeset: 0cfbde1bb515b4b4e0ece8fda02669e754437e45
Author: Prakash M <prakash <at> qualiantech.com>
Date: Fri Jun 05 17:02:52 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.coupons/rev/0cfbde1bb515b4b4e0ece8fda02669e754437e45 [^]

Related to BUG-44290: Coupons are not linked to the discount in the order when used

* This is because coupon details structure in jsonorder is changed
* Coupons are placed inside discountsFromUser object.
* So fixed by fetching coupons from discountsFromUser object in jsonorder

---
M src/org/openbravo/retail/discounts/coupons/OrderLoaderHookCoupons.java
---
(0120717)
hgbot   
2020-06-06 07:29   
Repository: tools/automation/pi-mobile
Changeset: ba4f6da445e13b6d4eddc34108dcfc760008bbfe
Author: Prakash M <prakash <at> qualiantech.com>
Date: Sat Jun 06 10:58:07 2020 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/ba4f6da445e13b6d4eddc34108dcfc760008bbfe [^]

Related to BUG-44290: Included coupon code verification in CheckCouponsDiscounts test

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_coupons/CheckCouponsDiscounts.java
---
(0121008)
marvintm   
2020-06-24 08:19   
The same problem also happens here:

https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/blob/master/src/org/openbravo/retail/discounts/coupons/PreOrderLoaderHookCoupons.java [^]
(0121014)
hgbot   
2020-06-24 10:35   
Repository: erp/pmods/org.openbravo.retail.discounts.coupons
Changeset: c845585d599a80c10089dfdb717e0d4856819cb9
Author: Prakash M <prakash <at> qualiantech.com>
Date: Wed Jun 24 14:04:54 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.coupons/rev/c845585d599a80c10089dfdb717e0d4856819cb9 [^]

Fixed BUG-44290: Coupons are not linked to the discount in the order when used
* This is because coupon details structure in jsonorder is changed
* Coupons are placed inside discountsFromUser object.
* So fixed by fetching coupons from discountsFromUser object in jsonorder

* Fixed in PreOrderLoaderHookCoupons as well

---
M src/org/openbravo/retail/discounts/coupons/PreOrderLoaderHookCoupons.java
---