Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0044277
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2020-06-03 17:572020-06-05 13:58
Reportersebastien_lironView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityurgentResolutionfixedFixed in VersionRR20Q3
StatusclosedFix in branchFixed in SCM revisiond51a8f49b230
ProjectionnoneETAnoneTarget Versionpi
OSLinux 64 bitDatabasePostgreSQLJava version7.x
OS VersionOpenbravo Appliance 14.04Database version9.3.xAnt version1.9.x
Product VersionpiSCM revision 
Review Assigned Toguilleaer
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0044277: setMessage(msg, iserror), isError is not used in customer edit checkFields

Descriptionif we use setMessage(msg, iserror) for a customer field in the 'OB.OBPOSPointOfSale.UI.customers.edit_createcustomers' kind,
The isError is not used in the checkfieds ( function checkFields(items, customer) ) in saveCustomer method, only the msg.content is checked.
Steps To ReproduceBy example implement this function :

var origValueSet = OB.UI.CustomerTextProperty.prototype.valueSet;
OB.UI.CustomerTextProperty.prototype.valueSet = _.wrap(
  OB.UI.CustomerTextProperty.prototype.valueSet,
  function(wrapped, inSender, inEvent) {
    var valueSet = _.bind(origValueSet, this);

    if (this.modelProperty == 'email')
    {
       this.owner.owner.setMessage('this is a test', false);
    }
);

then do save in the pos, the field should show the message, but then it is impossible to save, even if it's not an error.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0120663)
hgbot (developer)
2020-06-04 15:42

Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 986526711f4c72dc4fa4021a74b166bb92ca0db0
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Jun 04 19:12:37 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/986526711f4c72dc4fa4021a74b166bb92ca0db0 [^]

Related to issue-44277: FormElement should return false if Message is not set

* Renamed FormElement object error to errorInField as error is global method in enyo

---
M web/org.openbravo.mobile.core/source/component/ob-form.js
---
(0120664)
hgbot (developer)
2020-06-04 15:43

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d51a8f49b230346ac94cb153b3aa024b1ea17ec4
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Jun 04 19:12:49 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d51a8f49b230346ac94cb153b3aa024b1ea17ec4 [^]

Fixed issue-44277: Field error should be checked before Saving Customer and Address

* When saving Customer/CustomerAddress,
  CustomeerTextProperty should be checked with Message Content and Error State

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customeraddress/components/sharedcomponents.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customers/components/sharedcomponents.js
---
(0120693)
sebastien_liron (reporter)
2020-06-05 11:02

Sorry but the fix as it is won't solution my request, the msg content is till checked, it should not be the case, or if you maintain this please give me a solution to override this behaviour.
(0120710)
sebastien_liron (reporter)
2020-06-05 13:57

So the fix will perform well for my need after all, as discussed with team

- Issue History
Date Modified Username Field Change
2020-06-03 17:57 sebastien_liron New Issue
2020-06-03 17:57 sebastien_liron Assigned To => Retail
2020-06-03 17:57 sebastien_liron Triggers an Emergency Pack => No
2020-06-04 01:48 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2020-06-04 14:29 guillermogil Resolution time => 1593036000
2020-06-04 14:29 guillermogil Category Retail API => Web POS
2020-06-04 15:07 ranjith_qualiantech_com Status new => scheduled
2020-06-04 15:42 hgbot Checkin
2020-06-04 15:42 hgbot Note Added: 0120663
2020-06-04 15:43 hgbot Checkin
2020-06-04 15:43 hgbot Note Added: 0120664
2020-06-04 15:43 hgbot Status scheduled => resolved
2020-06-04 15:43 hgbot Resolution open => fixed
2020-06-04 15:43 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d51a8f49b230346ac94cb153b3aa024b1ea17ec4 [^]
2020-06-04 16:19 guilleaer Review Assigned To => guilleaer
2020-06-04 16:19 guilleaer Status resolved => closed
2020-06-04 16:19 guilleaer Fixed in Version => RR20Q3
2020-06-05 11:02 sebastien_liron Note Added: 0120693
2020-06-05 11:02 sebastien_liron Status closed => new
2020-06-05 13:57 sebastien_liron Note Added: 0120710
2020-06-05 13:57 sebastien_liron Status new => scheduled
2020-06-05 13:57 sebastien_liron Status scheduled => resolved
2020-06-05 13:58 sebastien_liron Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker