Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044277Retail ModulesWeb POSpublic2020-06-03 17:572020-06-05 13:58
Reportersebastien_liron 
Assigned Toranjith_qualiantech_com 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionOpenbravo Appliance 14.04
Product Versionpi 
Target VersionpiFixed in VersionRR20Q3 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0044277: setMessage(msg, iserror), isError is not used in customer edit checkFields
Descriptionif we use setMessage(msg, iserror) for a customer field in the 'OB.OBPOSPointOfSale.UI.customers.edit_createcustomers' kind,
The isError is not used in the checkfieds ( function checkFields(items, customer) ) in saveCustomer method, only the msg.content is checked.
Steps To ReproduceBy example implement this function :

var origValueSet = OB.UI.CustomerTextProperty.prototype.valueSet;
OB.UI.CustomerTextProperty.prototype.valueSet = _.wrap(
  OB.UI.CustomerTextProperty.prototype.valueSet,
  function(wrapped, inSender, inEvent) {
    var valueSet = _.bind(origValueSet, this);

    if (this.modelProperty == 'email')
    {
       this.owner.owner.setMessage('this is a test', false);
    }
);

then do save in the pos, the field should show the message, but then it is impossible to save, even if it's not an error.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-06-03 17:57sebastien_lironNew Issue
2020-06-03 17:57sebastien_lironAssigned To => Retail
2020-06-03 17:57sebastien_lironOBNetwork customer => Gold
2020-06-03 17:57sebastien_lironTriggers an Emergency Pack => No
2020-06-04 01:48ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2020-06-04 14:29guillermogilResolution time => 1593036000
2020-06-04 14:29guillermogilCategoryRetail API => Web POS
2020-06-04 15:07ranjith_qualiantech_comStatusnew => scheduled
2020-06-04 15:42hgbotCheckin
2020-06-04 15:42hgbotNote Added: 0120663
2020-06-04 15:43hgbotCheckin
2020-06-04 15:43hgbotNote Added: 0120664
2020-06-04 15:43hgbotStatusscheduled => resolved
2020-06-04 15:43hgbotResolutionopen => fixed
2020-06-04 15:43hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d51a8f49b230346ac94cb153b3aa024b1ea17ec4 [^]
2020-06-04 16:19guilleaerReview Assigned To => guilleaer
2020-06-04 16:19guilleaerStatusresolved => closed
2020-06-04 16:19guilleaerFixed in Version => RR20Q3
2020-06-05 11:02sebastien_lironNote Added: 0120693
2020-06-05 11:02sebastien_lironStatusclosed => new
2020-06-05 13:57sebastien_lironNote Added: 0120710
2020-06-05 13:57sebastien_lironStatusnew => scheduled
2020-06-05 13:57sebastien_lironStatusscheduled => resolved
2020-06-05 13:58sebastien_lironStatusresolved => closed

Notes
(0120663)
hgbot   
2020-06-04 15:42   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 986526711f4c72dc4fa4021a74b166bb92ca0db0
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Jun 04 19:12:37 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/986526711f4c72dc4fa4021a74b166bb92ca0db0 [^]

Related to issue-44277: FormElement should return false if Message is not set

* Renamed FormElement object error to errorInField as error is global method in enyo

---
M web/org.openbravo.mobile.core/source/component/ob-form.js
---
(0120664)
hgbot   
2020-06-04 15:43   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d51a8f49b230346ac94cb153b3aa024b1ea17ec4
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Jun 04 19:12:49 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d51a8f49b230346ac94cb153b3aa024b1ea17ec4 [^]

Fixed issue-44277: Field error should be checked before Saving Customer and Address

* When saving Customer/CustomerAddress,
  CustomeerTextProperty should be checked with Message Content and Error State

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customeraddress/components/sharedcomponents.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customers/components/sharedcomponents.js
---
(0120693)
sebastien_liron   
2020-06-05 11:02   
Sorry but the fix as it is won't solution my request, the msg content is till checked, it should not be the case, or if you maintain this please give me a solution to override this behaviour.
(0120710)
sebastien_liron   
2020-06-05 13:57   
So the fix will perform well for my need after all, as discussed with team