Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0044227 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Modules] Advanced Warehouse Operations | minor | have not tried | 2020-05-28 13:48 | 2020-06-08 10:54 | |||
Reporter | inigo_lerga | View Status | public | |||||
Assigned To | inigo_lerga | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | ||||
Status | closed | Fix in branch | Fixed in SCM revision | 0911b7b6c285 | ||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Merge Request Status | ||||||||
Regression date | ||||||||
Regression introduced by commit | ||||||||
Regression level | ||||||||
Review Assigned To | dmiguelez | |||||||
Support ticket | ||||||||
OBNetwork customer | No | |||||||
Regression introduced in release | ||||||||
Summary | 0044227: Apply new HQL Style in TaskAssigment.java | |||||||
Description | TaskAssigment.java has HQL queries with: - the HQL is hard to read because of formatting - and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default | |||||||
Steps To Reproduce | - | |||||||
Proposed Solution | Follow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^] | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
![]() |
|||||||||
|
![]() |
|
(0120406) inigo_lerga (viewer) 2020-05-28 14:20 |
--Test Plan Mantis HQL-- Beforehand, the environment needs to have AWO modules installed and working. Execute the OLBTestSuite.java JUnit tests file from advancedwarehouseoperations.operatorloadbalancing. #In this moment the modified HQLs are executed# |
(0120725) hgbot (developer) 2020-06-08 10:53 |
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.operatorloadbalancing Changeset: 0911b7b6c28533b2b3b926b8d632e62a2cd04d11 Author: IƱigo Lerga <inigo.lerga <at> openbravo.com> Date: Thu May 28 14:22:24 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.operatorloadbalancing/rev/0911b7b6c28533b2b3b926b8d632e62a2cd04d11 [^] fixes BUG-44227:Applied new HQL Style --- M src/org/openbravo/warehouse/advancedwarehouseoperations/operatorloadbalancing/ad_process/TaskAssigment.java --- |
(0120726) hgbot (developer) 2020-06-08 10:53 |
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.operatorloadbalancing Changeset: 26ae98b7af0a58dd5b6ee63fce9afd027380b431 Author: David Miguelez <david.miguelez <at> openbravo.com> Date: Mon Jun 08 10:53:29 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.operatorloadbalancing/rev/26ae98b7af0a58dd5b6ee63fce9afd027380b431 [^] Related to ISSUE-44227. Remove unnecessary variable to store the query --- M src/org/openbravo/warehouse/advancedwarehouseoperations/operatorloadbalancing/ad_process/TaskAssigment.java --- |
(0120727) dmiguelez (viewer) 2020-06-08 10:54 |
Code Review + Testing Ok |
![]() |
|||
Date Modified | Username | Field | Change |
2020-05-28 13:48 | inigo_lerga | New Issue | |
2020-05-28 13:48 | inigo_lerga | Assigned To | => inigo_lerga |
2020-05-28 13:48 | inigo_lerga | OBNetwork customer | => No |
2020-05-28 13:49 | inigo_lerga | Relationship added | related to 0041287 |
2020-05-28 13:49 | inigo_lerga | Status | new => scheduled |
2020-05-28 14:20 | inigo_lerga | Note Added: 0120406 | |
2020-06-08 10:53 | hgbot | Checkin | |
2020-06-08 10:53 | hgbot | Note Added: 0120725 | |
2020-06-08 10:53 | hgbot | Status | scheduled => resolved |
2020-06-08 10:53 | hgbot | Resolution | open => fixed |
2020-06-08 10:53 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.operatorloadbalancing/rev/0911b7b6c28533b2b3b926b8d632e62a2cd04d11 [^] |
2020-06-08 10:53 | hgbot | Checkin | |
2020-06-08 10:53 | hgbot | Note Added: 0120726 | |
2020-06-08 10:54 | dmiguelez | Review Assigned To | => dmiguelez |
2020-06-08 10:54 | dmiguelez | Note Added: 0120727 | |
2020-06-08 10:54 | dmiguelez | Status | resolved => closed |
2022-09-06 17:18 | caristu | Category | Advance Warehouse Operations => Advanced Warehouse Operations |
Copyright © 2000 - 2009 MantisBT Group |