Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044227ModulesAdvanced Warehouse Operationspublic2020-05-28 13:482020-06-08 10:54
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customer
Regression introduced in release
Summary0044227: Apply new HQL Style in TaskAssigment.java
DescriptionTaskAssigment.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-28 13:48inigo_lergaNew Issue
2020-05-28 13:48inigo_lergaAssigned To => inigo_lerga
2020-05-28 13:49inigo_lergaRelationship addedrelated to 0041287
2020-05-28 13:49inigo_lergaStatusnew => scheduled
2020-05-28 14:20inigo_lergaNote Added: 0120406
2020-06-08 10:53hgbotCheckin
2020-06-08 10:53hgbotNote Added: 0120725
2020-06-08 10:53hgbotStatusscheduled => resolved
2020-06-08 10:53hgbotResolutionopen => fixed
2020-06-08 10:53hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.operatorloadbalancing/rev/0911b7b6c28533b2b3b926b8d632e62a2cd04d11 [^]
2020-06-08 10:53hgbotCheckin
2020-06-08 10:53hgbotNote Added: 0120726
2020-06-08 10:54dmiguelezReview Assigned To => dmiguelez
2020-06-08 10:54dmiguelezNote Added: 0120727
2020-06-08 10:54dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0120406)
inigo_lerga   
2020-05-28 14:20   
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
Execute the OLBTestSuite.java JUnit tests file
from advancedwarehouseoperations.operatorloadbalancing.
#In this moment the modified HQLs are executed#
(0120725)
hgbot   
2020-06-08 10:53   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.operatorloadbalancing
Changeset: 0911b7b6c28533b2b3b926b8d632e62a2cd04d11
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Thu May 28 14:22:24 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.operatorloadbalancing/rev/0911b7b6c28533b2b3b926b8d632e62a2cd04d11 [^]

fixes BUG-44227:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/operatorloadbalancing/ad_process/TaskAssigment.java
---
(0120726)
hgbot   
2020-06-08 10:53   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.operatorloadbalancing
Changeset: 26ae98b7af0a58dd5b6ee63fce9afd027380b431
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon Jun 08 10:53:29 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.operatorloadbalancing/rev/26ae98b7af0a58dd5b6ee63fce9afd027380b431 [^]

Related to ISSUE-44227. Remove unnecessary variable to store the query

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/operatorloadbalancing/ad_process/TaskAssigment.java
---
(0120727)
dmiguelez   
2020-06-08 10:54   
Code Review + Testing Ok