Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0044180
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Advanced Warehouse Operationsminorhave not tried2020-05-25 11:402020-06-04 17:52
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision8096486d4464
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Regression introduced in release
Summary

0044180: Apply new HQL Style in TaskGeneratorBatchWavePicking.java

DescriptionTaskGeneratorBatchWavePicking.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to design defect 0041287 acknowledgedTriage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 

-  Notes
(0120230)
inigo_lerga (reporter)
2020-05-25 12:39

As the AWO-QA Admin - AWO-QA role in Backend:
  - Go to Process Request window and create a new record
    for US West Coast. Set "Generate Batched-Wave Picking Tasks"
    as Process, and "Run Inmediately" as Timing.
    Press the Schedule button.
#In this moment the modified HQL is executed#
(0120674)
hgbot (developer)
2020-06-04 17:51

Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.batchwavepicking
Changeset: 8096486d446499b23d3489ae29890da6ccb8afc8
Author: IƱigo Lerga <inigo.lerga <at> openbravo.com>
Date: Mon May 25 12:32:19 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.batchwavepicking/rev/8096486d446499b23d3489ae29890da6ccb8afc8 [^]

fixes BUG-44180:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/batchwavepicking/utils/TaskGeneratorBatchWavePicking.java
---
(0120675)
hgbot (developer)
2020-06-04 17:52

Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.batchwavepicking
Changeset: 2736abf4df203afdec08bf1965dd329886ceb1b7
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Jun 04 17:51:54 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.batchwavepicking/rev/2736abf4df203afdec08bf1965dd329886ceb1b7 [^]

Related to ISSUE-44180. Format changes to improve redability

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/batchwavepicking/utils/TaskGeneratorBatchWavePicking.java
---
(0120676)
dmiguelez (developer)
2020-06-04 17:52

Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-05-25 11:40 inigo_lerga New Issue
2020-05-25 11:40 inigo_lerga Assigned To => inigo_lerga
2020-05-25 11:40 inigo_lerga Relationship added related to 0041287
2020-05-25 11:40 inigo_lerga Status new => scheduled
2020-05-25 12:39 inigo_lerga Note Added: 0120230
2020-06-04 17:51 hgbot Checkin
2020-06-04 17:51 hgbot Note Added: 0120674
2020-06-04 17:51 hgbot Status scheduled => resolved
2020-06-04 17:51 hgbot Resolution open => fixed
2020-06-04 17:51 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.batchwavepicking/rev/8096486d446499b23d3489ae29890da6ccb8afc8 [^]
2020-06-04 17:52 hgbot Checkin
2020-06-04 17:52 hgbot Note Added: 0120675
2020-06-04 17:52 dmiguelez Review Assigned To => dmiguelez
2020-06-04 17:52 dmiguelez Note Added: 0120676
2020-06-04 17:52 dmiguelez Status resolved => closed
2022-09-06 17:18 caristu Category Advance Warehouse Operations => Advanced Warehouse Operations


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker