Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044180ModulesAdvanced Warehouse Operationspublic2020-05-25 11:402020-06-04 17:52
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customer
Regression introduced in release
Summary0044180: Apply new HQL Style in TaskGeneratorBatchWavePicking.java
DescriptionTaskGeneratorBatchWavePicking.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-25 11:40inigo_lergaNew Issue
2020-05-25 11:40inigo_lergaAssigned To => inigo_lerga
2020-05-25 11:40inigo_lergaRelationship addedrelated to 0041287
2020-05-25 11:40inigo_lergaStatusnew => scheduled
2020-05-25 12:39inigo_lergaNote Added: 0120230
2020-06-04 17:51hgbotCheckin
2020-06-04 17:51hgbotNote Added: 0120674
2020-06-04 17:51hgbotStatusscheduled => resolved
2020-06-04 17:51hgbotResolutionopen => fixed
2020-06-04 17:51hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.batchwavepicking/rev/8096486d446499b23d3489ae29890da6ccb8afc8 [^]
2020-06-04 17:52hgbotCheckin
2020-06-04 17:52hgbotNote Added: 0120675
2020-06-04 17:52dmiguelezReview Assigned To => dmiguelez
2020-06-04 17:52dmiguelezNote Added: 0120676
2020-06-04 17:52dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0120230)
inigo_lerga   
2020-05-25 12:39   
As the AWO-QA Admin - AWO-QA role in Backend:
  - Go to Process Request window and create a new record
    for US West Coast. Set "Generate Batched-Wave Picking Tasks"
    as Process, and "Run Inmediately" as Timing.
    Press the Schedule button.
#In this moment the modified HQL is executed#
(0120674)
hgbot   
2020-06-04 17:51   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.batchwavepicking
Changeset: 8096486d446499b23d3489ae29890da6ccb8afc8
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Mon May 25 12:32:19 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.batchwavepicking/rev/8096486d446499b23d3489ae29890da6ccb8afc8 [^]

fixes BUG-44180:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/batchwavepicking/utils/TaskGeneratorBatchWavePicking.java
---
(0120675)
hgbot   
2020-06-04 17:52   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.batchwavepicking
Changeset: 2736abf4df203afdec08bf1965dd329886ceb1b7
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Jun 04 17:51:54 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.batchwavepicking/rev/2736abf4df203afdec08bf1965dd329886ceb1b7 [^]

Related to ISSUE-44180. Format changes to improve redability

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/batchwavepicking/utils/TaskGeneratorBatchWavePicking.java
---
(0120676)
dmiguelez   
2020-06-04 17:52   
Code Review + Testing Ok