Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0044178
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Advanced Warehouse Operationsminorhave not tried2020-05-25 10:162020-06-04 17:29
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision03a48cf381f5
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Regression introduced in release
Summary

0044178: Apply new HQL Style in SaleOrderBatchForPicking.java

DescriptionSaleOrderBatchForPicking.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0041287 acknowledgedTriage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 

-  Notes
(0120245)
inigo_lerga (reporter)
2020-05-25 14:15

 --Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
Execute the OBAWOPLTestSuite.java JUnit tests file
from advancedwarehouseoperations.batchwavepicking.
#In this moment the modified HQLs are executed#
(0120671)
hgbot (developer)
2020-06-04 17:29

 Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.batchwavepicking
Changeset: 03a48cf381f51bc151ab3bd7234444c48bf1a077
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Mon May 25 14:23:13 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.batchwavepicking/rev/03a48cf381f51bc151ab3bd7234444c48bf1a077 [^]

fixes BUG-44178:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/batchwavepicking/utils/SaleOrderBatchForPicking.java
---
(0120672)
hgbot (developer)
2020-06-04 17:29

 Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.batchwavepicking
Changeset: 3b077e99fbcc15e8f797c4756daf9852eb9addfd
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Jun 04 17:29:11 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.batchwavepicking/rev/3b077e99fbcc15e8f797c4756daf9852eb9addfd [^]

Related to ISSUE-44178. Format changes to improve redability

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/batchwavepicking/utils/SaleOrderBatchForPicking.java
---
(0120673)
dmiguelez (developer)
2020-06-04 17:29

 Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-05-25 10:16 inigo_lerga New Issue
2020-05-25 10:16 inigo_lerga Assigned To => inigo_lerga
2020-05-25 10:16 inigo_lerga Relationship added related to 0041287
2020-05-25 10:16 inigo_lerga Status new => scheduled
2020-05-25 14:15 inigo_lerga Note Added: 0120245
2020-06-04 17:29 hgbot Checkin
2020-06-04 17:29 hgbot Note Added: 0120671
2020-06-04 17:29 hgbot Status scheduled => resolved
2020-06-04 17:29 hgbot Resolution open => fixed
2020-06-04 17:29 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.batchwavepicking/rev/03a48cf381f51bc151ab3bd7234444c48bf1a077 [^]
2020-06-04 17:29 hgbot Checkin
2020-06-04 17:29 hgbot Note Added: 0120672
2020-06-04 17:29 dmiguelez Review Assigned To => dmiguelez
2020-06-04 17:29 dmiguelez Note Added: 0120673
2020-06-04 17:29 dmiguelez Status resolved => closed
2022-09-06 17:18 caristu Category Advance Warehouse Operations => Advanced Warehouse Operations

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker