Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044178ModulesAdvanced Warehouse Operationspublic2020-05-25 10:162020-06-04 17:29
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customer
Regression introduced in release
Summary0044178: Apply new HQL Style in SaleOrderBatchForPicking.java
DescriptionSaleOrderBatchForPicking.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-25 10:16inigo_lergaNew Issue
2020-05-25 10:16inigo_lergaAssigned To => inigo_lerga
2020-05-25 10:16inigo_lergaRelationship addedrelated to 0041287
2020-05-25 10:16inigo_lergaStatusnew => scheduled
2020-05-25 14:15inigo_lergaNote Added: 0120245
2020-06-04 17:29hgbotCheckin
2020-06-04 17:29hgbotNote Added: 0120671
2020-06-04 17:29hgbotStatusscheduled => resolved
2020-06-04 17:29hgbotResolutionopen => fixed
2020-06-04 17:29hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.batchwavepicking/rev/03a48cf381f51bc151ab3bd7234444c48bf1a077 [^]
2020-06-04 17:29hgbotCheckin
2020-06-04 17:29hgbotNote Added: 0120672
2020-06-04 17:29dmiguelezReview Assigned To => dmiguelez
2020-06-04 17:29dmiguelezNote Added: 0120673
2020-06-04 17:29dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0120245)
inigo_lerga   
2020-05-25 14:15   
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
Execute the OBAWOPLTestSuite.java JUnit tests file
from advancedwarehouseoperations.batchwavepicking.
#In this moment the modified HQLs are executed#
(0120671)
hgbot   
2020-06-04 17:29   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.batchwavepicking
Changeset: 03a48cf381f51bc151ab3bd7234444c48bf1a077
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Mon May 25 14:23:13 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.batchwavepicking/rev/03a48cf381f51bc151ab3bd7234444c48bf1a077 [^]

fixes BUG-44178:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/batchwavepicking/utils/SaleOrderBatchForPicking.java
---
(0120672)
hgbot   
2020-06-04 17:29   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.batchwavepicking
Changeset: 3b077e99fbcc15e8f797c4756daf9852eb9addfd
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Jun 04 17:29:11 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.batchwavepicking/rev/3b077e99fbcc15e8f797c4756daf9852eb9addfd [^]

Related to ISSUE-44178. Format changes to improve redability

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/batchwavepicking/utils/SaleOrderBatchForPicking.java
---
(0120673)
dmiguelez   
2020-06-04 17:29   
Code Review + Testing Ok