Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0044104 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Modules] Advanced Warehouse Operations | minor | have not tried | 2020-05-19 13:15 | 2020-06-03 10:52 | |||
Reporter | inigo_lerga | View Status | public | |||||
Assigned To | inigo_lerga | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | ||||
Status | closed | Fix in branch | Fixed in SCM revision | bc7bbb29c6b3 | ||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Regression date | ||||||||
Regression introduced by commit | ||||||||
Regression level | ||||||||
Review Assigned To | dmiguelez | |||||||
Regression introduced in release | ||||||||
Summary | 0044104: Apply new HQL Style in TaskErrorsUtils.java | |||||||
Description | TaskErrorsUtils.java has HQL queries with: - the HQL is hard to read because of formatting - and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default | |||||||
Steps To Reproduce | - | |||||||
Proposed Solution | Follow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^] | |||||||
Tags | No tags attached. | |||||||
Attached Files | TESTING.diff [^] (2,208 bytes) 2020-05-19 16:45 [Show Content] | |||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | |||||||||
|
Notes | |
(0120060) inigo_lerga (reporter) 2020-05-19 16:45 |
--Test Plan Mantis HQL-- Beforehand, the environment needs to have AWO modules installed and working. Also, in the java file "CentralBroker", the TESTING.diff patch attached to this Issue needs to be applied ONLY FOR TESTING PURPOSES (it is not the fix for this issue). As the AWO-QA Admin - AWO-QA role in Backend: - Go to Purchase Order window and create a new record with any Business Partner desired. Go to Lines Tab and create a new Line with Ale Beer as product and 5 units as Operative Quantity. Book the Purchase Order and press the Receive button. Select AWO_US_W user and Done button. As the AWO_US_W user in AWO Front End: - Refresh the Tasks List and open the just generated one with 5 units of Ale Beer. Confirm the Task. An error should rise. As the AWO-QA Admin - AWO-QA role in Backend: - Go to Batch of Tasks window and open the one generated by the previously created Purchase Order. Select the only Task shown in the Task Tab. Un-assign it from any user and delete the Task. #In this moment the modified HQLs are executed# |
(0120569) hgbot (developer) 2020-06-03 10:51 |
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations Changeset: bc7bbb29c6b37bd9b76e5c2541e1edd423be8d35 Author: Iñigo Lerga <inigo.lerga <at> openbravo.com> Date: Tue May 19 16:46:43 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/bc7bbb29c6b37bd9b76e5c2541e1edd423be8d35 [^] fixes BUG-44104:Applied new HQL Style --- M src/org/openbravo/warehouse/advancedwarehouseoperations/utils/TaskErrorsUtils.java --- |
(0120570) hgbot (developer) 2020-06-03 10:51 |
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations Changeset: 23f110c33d73f19c4d87458d49317b9fd9f9a489 Author: David Miguelez <david.miguelez <at> openbravo.com> Date: Wed Jun 03 10:51:18 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/23f110c33d73f19c4d87458d49317b9fd9f9a489 [^] Related to ISSUE-44104. Format changes to improve redability --- M src/org/openbravo/warehouse/advancedwarehouseoperations/utils/TaskErrorsUtils.java --- |
(0120571) dmiguelez (developer) 2020-06-03 10:52 |
Code Review + Testing Ok |
Issue History | |||
Date Modified | Username | Field | Change |
2020-05-19 13:15 | inigo_lerga | New Issue | |
2020-05-19 13:15 | inigo_lerga | Assigned To | => inigo_lerga |
2020-05-19 13:15 | inigo_lerga | Relationship added | related to 0041287 |
2020-05-19 13:16 | inigo_lerga | Status | new => scheduled |
2020-05-19 16:45 | inigo_lerga | Note Added: 0120060 | |
2020-05-19 16:45 | inigo_lerga | File Added: TESTING.diff | |
2020-06-03 10:51 | hgbot | Checkin | |
2020-06-03 10:51 | hgbot | Note Added: 0120569 | |
2020-06-03 10:51 | hgbot | Status | scheduled => resolved |
2020-06-03 10:51 | hgbot | Resolution | open => fixed |
2020-06-03 10:51 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/bc7bbb29c6b37bd9b76e5c2541e1edd423be8d35 [^] |
2020-06-03 10:51 | hgbot | Checkin | |
2020-06-03 10:51 | hgbot | Note Added: 0120570 | |
2020-06-03 10:52 | dmiguelez | Review Assigned To | => dmiguelez |
2020-06-03 10:52 | dmiguelez | Note Added: 0120571 | |
2020-06-03 10:52 | dmiguelez | Status | resolved => closed |
2022-09-06 17:18 | caristu | Category | Advance Warehouse Operations => Advanced Warehouse Operations |
Copyright © 2000 - 2009 MantisBT Group |