Openbravo Issue Tracking System - Modules
View Issue Details
0044104ModulesAdvanced Warehouse Operationspublic2020-05-19 13:152020-06-03 10:52
inigo_lerga 
inigo_lerga 
normalminorhave not tried
closedfixed 
5
 
 
dmiguelez
0044104: Apply new HQL Style in TaskErrorsUtils.java
TaskErrorsUtils.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
-
Follow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
No tags attached.
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
diff TESTING.diff (2,208) 2020-05-19 16:45
https://issues.openbravo.com/file_download.php?file_id=14504&type=bug
Issue History
2020-05-19 13:15inigo_lergaNew Issue
2020-05-19 13:15inigo_lergaAssigned To => inigo_lerga
2020-05-19 13:15inigo_lergaRelationship addedrelated to 0041287
2020-05-19 13:16inigo_lergaStatusnew => scheduled
2020-05-19 16:45inigo_lergaNote Added: 0120060
2020-05-19 16:45inigo_lergaFile Added: TESTING.diff
2020-06-03 10:51hgbotCheckin
2020-06-03 10:51hgbotNote Added: 0120569
2020-06-03 10:51hgbotStatusscheduled => resolved
2020-06-03 10:51hgbotResolutionopen => fixed
2020-06-03 10:51hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/bc7bbb29c6b37bd9b76e5c2541e1edd423be8d35 [^]
2020-06-03 10:51hgbotCheckin
2020-06-03 10:51hgbotNote Added: 0120570
2020-06-03 10:52dmiguelezReview Assigned To => dmiguelez
2020-06-03 10:52dmiguelezNote Added: 0120571
2020-06-03 10:52dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0120060)
inigo_lerga   
2020-05-19 16:45   
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working. Also, in the java file "CentralBroker",
the TESTING.diff patch attached to this Issue needs to be applied
ONLY FOR TESTING PURPOSES (it is not the fix for this issue).

As the AWO-QA Admin - AWO-QA role in Backend:
  - Go to Purchase Order window and create a new record
    with any Business Partner desired.
    Go to Lines Tab and create a new Line with Ale Beer as
    product and 5 units as Operative Quantity.
    Book the Purchase Order and press the Receive button.
    Select AWO_US_W user and Done button.

As the AWO_US_W user in AWO Front End:
  - Refresh the Tasks List and open the just generated one
    with 5 units of Ale Beer. Confirm the Task.
    An error should rise.

As the AWO-QA Admin - AWO-QA role in Backend:
  - Go to Batch of Tasks window and open the one generated by the
    previously created Purchase Order.
    Select the only Task shown in the Task Tab. Un-assign it from any
    user and delete the Task.
#In this moment the modified HQLs are executed#
(0120569)
hgbot   
2020-06-03 10:51   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: bc7bbb29c6b37bd9b76e5c2541e1edd423be8d35
Author: IƱigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue May 19 16:46:43 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/bc7bbb29c6b37bd9b76e5c2541e1edd423be8d35 [^]

fixes BUG-44104:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/utils/TaskErrorsUtils.java
---
(0120570)
hgbot   
2020-06-03 10:51   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 23f110c33d73f19c4d87458d49317b9fd9f9a489
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Jun 03 10:51:18 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/23f110c33d73f19c4d87458d49317b9fd9f9a489 [^]

Related to ISSUE-44104. Format changes to improve redability

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/utils/TaskErrorsUtils.java
---
(0120571)
dmiguelez   
2020-06-03 10:52   
Code Review + Testing Ok