Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0044103
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Advanced Warehouse Operationsminorhave not tried2020-05-19 12:222020-06-02 12:09
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisionb239c0879505
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customerNo
Regression introduced in release
Summary

0044103: Apply new HQL Style in OBAWOUserContactUtils.java

DescriptionOBAWOUserContactUtils.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0041287 acknowledgedTriage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 

-  Notes
(0120031)
inigo_lerga (viewer)
2020-05-19 13:05

 --Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.

As the AWO-QA Admin - AWO-QA role in Backend:
  - Go to Batch of Tasks window and open the record
    with "1022377" as Batch of Tasks Document Number.
    Select one of the Tasks present in the Task Tab.
    Press the Assign button, select "AWO_US_W" as user
    assigned and Enable the Override User Asignment checkbox.
    Press Done.
#In this moment the modified HQL is executed#

  - Select one of the Tasks present in the Task Tab.
    Press the Un-assign button and Done button.
#In this moment the modified HQL is executed#
(0120538)
hgbot (developer)
2020-06-02 12:08

 Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: b239c087950539f0d7b1442c541393ce31a79c85
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue May 19 13:06:51 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/b239c087950539f0d7b1442c541393ce31a79c85 [^]

fixes BUG-44103:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/utils/OBAWOUserContactUtils.java
---
(0120539)
dmiguelez (viewer)
2020-06-02 12:09

 Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-05-19 12:22 inigo_lerga New Issue
2020-05-19 12:22 inigo_lerga Assigned To => inigo_lerga
2020-05-19 12:22 inigo_lerga OBNetwork customer => No
2020-05-19 12:22 inigo_lerga Relationship added related to 0041287
2020-05-19 12:22 inigo_lerga Status new => scheduled
2020-05-19 13:05 inigo_lerga Note Added: 0120031
2020-06-02 12:08 hgbot Checkin
2020-06-02 12:08 hgbot Note Added: 0120538
2020-06-02 12:08 hgbot Status scheduled => resolved
2020-06-02 12:08 hgbot Resolution open => fixed
2020-06-02 12:08 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/b239c087950539f0d7b1442c541393ce31a79c85 [^]
2020-06-02 12:09 dmiguelez Review Assigned To => dmiguelez
2020-06-02 12:09 dmiguelez Note Added: 0120539
2020-06-02 12:09 dmiguelez Status resolved => closed
2022-09-06 17:18 caristu Category Advance Warehouse Operations => Advanced Warehouse Operations

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker