Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044103ModulesAdvanced Warehouse Operationspublic2020-05-19 12:222020-06-02 12:09
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customer
Regression introduced in release
Summary0044103: Apply new HQL Style in OBAWOUserContactUtils.java
DescriptionOBAWOUserContactUtils.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-19 12:22inigo_lergaNew Issue
2020-05-19 12:22inigo_lergaAssigned To => inigo_lerga
2020-05-19 12:22inigo_lergaRelationship addedrelated to 0041287
2020-05-19 12:22inigo_lergaStatusnew => scheduled
2020-05-19 13:05inigo_lergaNote Added: 0120031
2020-06-02 12:08hgbotCheckin
2020-06-02 12:08hgbotNote Added: 0120538
2020-06-02 12:08hgbotStatusscheduled => resolved
2020-06-02 12:08hgbotResolutionopen => fixed
2020-06-02 12:08hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/b239c087950539f0d7b1442c541393ce31a79c85 [^]
2020-06-02 12:09dmiguelezReview Assigned To => dmiguelez
2020-06-02 12:09dmiguelezNote Added: 0120539
2020-06-02 12:09dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0120031)
inigo_lerga   
2020-05-19 13:05   
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.

As the AWO-QA Admin - AWO-QA role in Backend:
  - Go to Batch of Tasks window and open the record
    with "1022377" as Batch of Tasks Document Number.
    Select one of the Tasks present in the Task Tab.
    Press the Assign button, select "AWO_US_W" as user
    assigned and Enable the Override User Asignment checkbox.
    Press Done.
#In this moment the modified HQL is executed#

  - Select one of the Tasks present in the Task Tab.
    Press the Un-assign button and Done button.
#In this moment the modified HQL is executed#
(0120538)
hgbot   
2020-06-02 12:08   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: b239c087950539f0d7b1442c541393ce31a79c85
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue May 19 13:06:51 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/b239c087950539f0d7b1442c541393ce31a79c85 [^]

fixes BUG-44103:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/utils/OBAWOUserContactUtils.java
---
(0120539)
dmiguelez   
2020-06-02 12:09   
Code Review + Testing Ok