Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0044094
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Advanced Warehouse Operationsminorhave not tried2020-05-18 16:152020-06-02 09:56
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisionda0f229df11e
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Regression introduced in release
Summary

0044094: Apply new HQL Style in InventoryCountGenerateList_NonShared.java

DescriptionInventoryCountGenerateList_NonShared.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0041287 acknowledgedTriage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 

-  Notes
(0120027)
inigo_lerga (reporter)
2020-05-19 11:52

 --Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
Execute the AWOTestSuite.java JUnit tests file.
#In this moment the modified HQLs are executed#
(0120524)
hgbot (developer)
2020-06-02 09:55

 Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: da0f229df11e10578b206e64c5627c7da1e05014
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue May 19 10:26:27 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/da0f229df11e10578b206e64c5627c7da1e05014 [^]

fixes BUG-44094:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/utils/inventorycount/InventoryCountGenerateList_NonShared.java
---
(0120525)
hgbot (developer)
2020-06-02 09:55

 Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: f8e7b41a5479941a56c48efacefd020457b4b9ca
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue May 19 10:28:23 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/f8e7b41a5479941a56c48efacefd020457b4b9ca [^]

related to ISSUE-44094: Applied new format to hql where clauses

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/utils/inventorycount/InventoryCountGenerateList.java
---
(0120526)
hgbot (developer)
2020-06-02 09:55

 Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 57e86412c35bedf057519279da85897cd61d58fe
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Tue Jun 02 09:55:15 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/57e86412c35bedf057519279da85897cd61d58fe [^]

Related to ISSUE-44094. Added missing hql condition in query.
Format changes to improve redability

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/utils/inventorycount/InventoryCountGenerateList_NonShared.java
---
(0120527)
dmiguelez (developer)
2020-06-02 09:56

 Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-05-18 16:15 inigo_lerga New Issue
2020-05-18 16:15 inigo_lerga Assigned To => inigo_lerga
2020-05-18 16:15 inigo_lerga Relationship added related to 0041287
2020-05-18 16:15 inigo_lerga Status new => scheduled
2020-05-19 11:52 inigo_lerga Note Added: 0120027
2020-06-02 09:55 hgbot Checkin
2020-06-02 09:55 hgbot Note Added: 0120524
2020-06-02 09:55 hgbot Status scheduled => resolved
2020-06-02 09:55 hgbot Resolution open => fixed
2020-06-02 09:55 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/da0f229df11e10578b206e64c5627c7da1e05014 [^]
2020-06-02 09:55 hgbot Checkin
2020-06-02 09:55 hgbot Note Added: 0120525
2020-06-02 09:55 hgbot Checkin
2020-06-02 09:55 hgbot Note Added: 0120526
2020-06-02 09:56 dmiguelez Review Assigned To => dmiguelez
2020-06-02 09:56 dmiguelez Note Added: 0120527
2020-06-02 09:56 dmiguelez Status resolved => closed
2022-09-06 17:18 caristu Category Advance Warehouse Operations => Advanced Warehouse Operations

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker