Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044094ModulesAdvanced Warehouse Operationspublic2020-05-18 16:152020-06-02 09:56
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customerNo
Regression introduced in release
Summary0044094: Apply new HQL Style in InventoryCountGenerateList_NonShared.java
DescriptionInventoryCountGenerateList_NonShared.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-18 16:15inigo_lergaNew Issue
2020-05-18 16:15inigo_lergaAssigned To => inigo_lerga
2020-05-18 16:15inigo_lergaOBNetwork customer => No
2020-05-18 16:15inigo_lergaRelationship addedrelated to 0041287
2020-05-18 16:15inigo_lergaStatusnew => scheduled
2020-05-19 11:52inigo_lergaNote Added: 0120027
2020-06-02 09:55hgbotCheckin
2020-06-02 09:55hgbotNote Added: 0120524
2020-06-02 09:55hgbotStatusscheduled => resolved
2020-06-02 09:55hgbotResolutionopen => fixed
2020-06-02 09:55hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/da0f229df11e10578b206e64c5627c7da1e05014 [^]
2020-06-02 09:55hgbotCheckin
2020-06-02 09:55hgbotNote Added: 0120525
2020-06-02 09:55hgbotCheckin
2020-06-02 09:55hgbotNote Added: 0120526
2020-06-02 09:56dmiguelezReview Assigned To => dmiguelez
2020-06-02 09:56dmiguelezNote Added: 0120527
2020-06-02 09:56dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0120027)
inigo_lerga   
2020-05-19 11:52   
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
Execute the AWOTestSuite.java JUnit tests file.
#In this moment the modified HQLs are executed#
(0120524)
hgbot   
2020-06-02 09:55   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: da0f229df11e10578b206e64c5627c7da1e05014
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue May 19 10:26:27 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/da0f229df11e10578b206e64c5627c7da1e05014 [^]

fixes BUG-44094:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/utils/inventorycount/InventoryCountGenerateList_NonShared.java
---
(0120525)
hgbot   
2020-06-02 09:55   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: f8e7b41a5479941a56c48efacefd020457b4b9ca
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue May 19 10:28:23 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/f8e7b41a5479941a56c48efacefd020457b4b9ca [^]

related to ISSUE-44094: Applied new format to hql where clauses

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/utils/inventorycount/InventoryCountGenerateList.java
---
(0120526)
hgbot   
2020-06-02 09:55   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 57e86412c35bedf057519279da85897cd61d58fe
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Tue Jun 02 09:55:15 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/57e86412c35bedf057519279da85897cd61d58fe [^]

Related to ISSUE-44094. Added missing hql condition in query.
Format changes to improve redability

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/utils/inventorycount/InventoryCountGenerateList_NonShared.java
---
(0120527)
dmiguelez   
2020-06-02 09:56   
Code Review + Testing Ok