Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0044076
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Advanced Warehouse Operationsminorhave not tried2020-05-15 13:172020-06-01 16:02
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision5f049dbf5965
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customerNo
Regression introduced in release
Summary

0044076: Apply new HQL Style in AWOReferencedInventoryUtils.java

DescriptionAWOReferencedInventoryUtils.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0041287 acknowledgedTriage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 

-  Notes
(0119981)
inigo_lerga (viewer)
2020-05-18 13:09

 --Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.

For two of the hqls:
Execute the AWOTestSuite.java JUnit tests file.
#In this moment the modified HQLs are executed#

One of them is deprecated and not used.

For another two hqls:
As the AWO_US_W user in AWO Front End:
  - Press the Box button and Create New Refence.
    Set any Reference number desired and AWOeii001-1
    as Reference Type.
    Press Create & Box.
#In this moment two of the modified HQLs are executed#

For the last one:
As the AWO-QA Admin - AWO-QA role in Backend:
  - Go to Referenced Inventory window and create a new
    record.
    Select Big Box as Referenced Inventory Type.
    Press the Box button and set Beverage101 as New
    Storage Bin.
    Select Ale Beer record from Beverage101 Storage Bin.
    Press Done button.
  - Go to Warehouse Operations window. Find the record for
    Beverage101 just generated and press the Put-Away button.
    Select the only record available and Done button.
#In this moment the modified HQL is executed#
(0120498)
hgbot (developer)
2020-06-01 16:01

 Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 5f049dbf59659ccd626d6a65cff17c60b2d0250e
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Mon May 18 13:16:15 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/5f049dbf59659ccd626d6a65cff17c60b2d0250e [^]

fixes BUG-44076:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/utils/AWOReferencedInventoryUtils.java
---
(0120499)
dmiguelez (viewer)
2020-06-01 16:02

 Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-05-15 13:17 inigo_lerga New Issue
2020-05-15 13:17 inigo_lerga Assigned To => inigo_lerga
2020-05-15 13:17 inigo_lerga OBNetwork customer => No
2020-05-15 13:17 inigo_lerga Relationship added related to 0041287
2020-05-15 13:17 inigo_lerga Status new => scheduled
2020-05-18 13:09 inigo_lerga Note Added: 0119981
2020-06-01 16:01 hgbot Checkin
2020-06-01 16:01 hgbot Note Added: 0120498
2020-06-01 16:01 hgbot Status scheduled => resolved
2020-06-01 16:01 hgbot Resolution open => fixed
2020-06-01 16:01 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/5f049dbf59659ccd626d6a65cff17c60b2d0250e [^]
2020-06-01 16:02 dmiguelez Review Assigned To => dmiguelez
2020-06-01 16:02 dmiguelez Note Added: 0120499
2020-06-01 16:02 dmiguelez Status resolved => closed
2022-09-06 17:18 caristu Category Advance Warehouse Operations => Advanced Warehouse Operations

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker