Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044076ModulesAdvanced Warehouse Operationspublic2020-05-15 13:172020-06-01 16:02
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customer
Regression introduced in release
Summary0044076: Apply new HQL Style in AWOReferencedInventoryUtils.java
DescriptionAWOReferencedInventoryUtils.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-15 13:17inigo_lergaNew Issue
2020-05-15 13:17inigo_lergaAssigned To => inigo_lerga
2020-05-15 13:17inigo_lergaRelationship addedrelated to 0041287
2020-05-15 13:17inigo_lergaStatusnew => scheduled
2020-05-18 13:09inigo_lergaNote Added: 0119981
2020-06-01 16:01hgbotCheckin
2020-06-01 16:01hgbotNote Added: 0120498
2020-06-01 16:01hgbotStatusscheduled => resolved
2020-06-01 16:01hgbotResolutionopen => fixed
2020-06-01 16:01hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/5f049dbf59659ccd626d6a65cff17c60b2d0250e [^]
2020-06-01 16:02dmiguelezReview Assigned To => dmiguelez
2020-06-01 16:02dmiguelezNote Added: 0120499
2020-06-01 16:02dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0119981)
inigo_lerga   
2020-05-18 13:09   
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.

For two of the hqls:
Execute the AWOTestSuite.java JUnit tests file.
#In this moment the modified HQLs are executed#

One of them is deprecated and not used.

For another two hqls:
As the AWO_US_W user in AWO Front End:
  - Press the Box button and Create New Refence.
    Set any Reference number desired and AWOeii001-1
    as Reference Type.
    Press Create & Box.
#In this moment two of the modified HQLs are executed#

For the last one:
As the AWO-QA Admin - AWO-QA role in Backend:
  - Go to Referenced Inventory window and create a new
    record.
    Select Big Box as Referenced Inventory Type.
    Press the Box button and set Beverage101 as New
    Storage Bin.
    Select Ale Beer record from Beverage101 Storage Bin.
    Press Done button.
  - Go to Warehouse Operations window. Find the record for
    Beverage101 just generated and press the Put-Away button.
    Select the only record available and Done button.
#In this moment the modified HQL is executed#
(0120498)
hgbot   
2020-06-01 16:01   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 5f049dbf59659ccd626d6a65cff17c60b2d0250e
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Mon May 18 13:16:15 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/5f049dbf59659ccd626d6a65cff17c60b2d0250e [^]

fixes BUG-44076:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/utils/AWOReferencedInventoryUtils.java
---
(0120499)
dmiguelez   
2020-06-01 16:02   
Code Review + Testing Ok