Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0044062
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Advanced Warehouse Operationsminorhave not tried2020-05-14 12:192020-05-21 15:51
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision91da1d83990d
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Regression introduced in release
Summary

0044062: Apply new HQL Style in StockProposedUtils.java

DescriptionStockProposedUtils.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0041287 acknowledgedTriage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 

-  Notes
(0119871)
inigo_lerga (reporter)
2020-05-14 12:26
edited on: 2020-05-15 11:56

 --Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
Execute the AWOTestSuite.java JUnit tests file.
#In this moment the modified HQLs is executed#
(0120136)
hgbot (developer)
2020-05-21 15:51

 Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 91da1d83990db246624e259ab29a5fb84287eea9
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Thu May 14 13:28:00 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/91da1d83990db246624e259ab29a5fb84287eea9 [^]

fixes BUG-44062:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/task/StockProposedUtils.java
---
(0120137)
hgbot (developer)
2020-05-21 15:51

 Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 0013cdc103838076e917071f4d779238186e44dc
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu May 21 15:51:03 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/0013cdc103838076e917071f4d779238186e44dc [^]

Related to ISSUE-44062 Code Review changes:
  * Modify the format of some queries to improve redability
  * Directly execute some queries instead of using a query variable

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/task/StockProposedUtils.java
---
(0120138)
dmiguelez (developer)
2020-05-21 15:51

 Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-05-14 12:19 inigo_lerga New Issue
2020-05-14 12:19 inigo_lerga Assigned To => inigo_lerga
2020-05-14 12:19 inigo_lerga Relationship added related to 0041287
2020-05-14 12:19 inigo_lerga Status new => scheduled
2020-05-14 12:26 inigo_lerga Note Added: 0119871
2020-05-15 11:56 inigo_lerga Note Edited: 0119871 View Revisions
2020-05-21 15:51 hgbot Checkin
2020-05-21 15:51 hgbot Note Added: 0120136
2020-05-21 15:51 hgbot Status scheduled => resolved
2020-05-21 15:51 hgbot Resolution open => fixed
2020-05-21 15:51 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/91da1d83990db246624e259ab29a5fb84287eea9 [^]
2020-05-21 15:51 hgbot Checkin
2020-05-21 15:51 hgbot Note Added: 0120137
2020-05-21 15:51 dmiguelez Review Assigned To => dmiguelez
2020-05-21 15:51 dmiguelez Note Added: 0120138
2020-05-21 15:51 dmiguelez Status resolved => closed
2022-09-06 17:18 caristu Category Advance Warehouse Operations => Advanced Warehouse Operations

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker