Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044062ModulesAdvanced Warehouse Operationspublic2020-05-14 12:192020-05-21 15:51
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customerNo
Regression introduced in release
Summary0044062: Apply new HQL Style in StockProposedUtils.java
DescriptionStockProposedUtils.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-14 12:19inigo_lergaNew Issue
2020-05-14 12:19inigo_lergaAssigned To => inigo_lerga
2020-05-14 12:19inigo_lergaOBNetwork customer => No
2020-05-14 12:19inigo_lergaRelationship addedrelated to 0041287
2020-05-14 12:19inigo_lergaStatusnew => scheduled
2020-05-14 12:26inigo_lergaNote Added: 0119871
2020-05-15 11:56inigo_lergaNote Edited: 0119871bug_revision_view_page.php?bugnote_id=0119871#r21030
2020-05-21 15:51hgbotCheckin
2020-05-21 15:51hgbotNote Added: 0120136
2020-05-21 15:51hgbotStatusscheduled => resolved
2020-05-21 15:51hgbotResolutionopen => fixed
2020-05-21 15:51hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/91da1d83990db246624e259ab29a5fb84287eea9 [^]
2020-05-21 15:51hgbotCheckin
2020-05-21 15:51hgbotNote Added: 0120137
2020-05-21 15:51dmiguelezReview Assigned To => dmiguelez
2020-05-21 15:51dmiguelezNote Added: 0120138
2020-05-21 15:51dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0119871)
inigo_lerga   
2020-05-14 12:26   
(edited on: 2020-05-15 11:56)
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
Execute the AWOTestSuite.java JUnit tests file.
#In this moment the modified HQLs is executed#
(0120136)
hgbot   
2020-05-21 15:51   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 91da1d83990db246624e259ab29a5fb84287eea9
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Thu May 14 13:28:00 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/91da1d83990db246624e259ab29a5fb84287eea9 [^]

fixes BUG-44062:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/task/StockProposedUtils.java
---
(0120137)
hgbot   
2020-05-21 15:51   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 0013cdc103838076e917071f4d779238186e44dc
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu May 21 15:51:03 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/0013cdc103838076e917071f4d779238186e44dc [^]

Related to ISSUE-44062 Code Review changes:
  * Modify the format of some queries to improve redability
  * Directly execute some queries instead of using a query variable

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/task/StockProposedUtils.java
---
(0120138)
dmiguelez   
2020-05-21 15:51   
Code Review + Testing Ok