Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0044054
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Advanced Warehouse Operationsminorhave not tried2020-05-13 16:172020-05-21 10:14
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision933ad6e5ac17
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Regression introduced in release
Summary

0044054: Apply new HQL Style in InternalRoutingAssignmentUtils.java

DescriptionInternalRoutingAssignmentUtils.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0041287 acknowledgedTriage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 

-  Notes
(0119852)
inigo_lerga (reporter)
2020-05-14 09:17
edited on: 2020-05-15 11:58

 --Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
Execute the AWOTestSuite.java JUnit tests file.
#In this moment the modified HQLs are executed#
(0120112)
hgbot (developer)
2020-05-21 10:13

 Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 933ad6e5ac174128584f18ab61f7939ee017f5b1
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Thu May 14 09:17:23 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/933ad6e5ac174128584f18ab61f7939ee017f5b1 [^]

fixes BUG-44054:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/task/InternalRoutingAssignmentUtils.java
---
(0120113)
hgbot (developer)
2020-05-21 10:13

 Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 06e0c21fa2f482d74327e5f74db7876db1f563e6
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu May 21 10:10:34 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/06e0c21fa2f482d74327e5f74db7876db1f563e6 [^]

Related to ISSUE-44054. Code Review changes
  * Removed formatter on/off to improve redability of the query
  * collapse some hql sentences to make them easier to read
  * Use class constants for ordering priority instead of hardcoded numbers

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/task/InternalRoutingAssignmentUtils.java
---
(0120114)
dmiguelez (developer)
2020-05-21 10:14

 Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-05-13 16:17 inigo_lerga New Issue
2020-05-13 16:17 inigo_lerga Assigned To => inigo_lerga
2020-05-13 16:17 inigo_lerga Relationship added related to 0041287
2020-05-13 16:18 inigo_lerga Status new => scheduled
2020-05-14 09:17 inigo_lerga Note Added: 0119852
2020-05-15 11:57 inigo_lerga Note Edited: 0119852 View Revisions
2020-05-15 11:58 inigo_lerga Note Edited: 0119852 View Revisions
2020-05-21 10:13 hgbot Checkin
2020-05-21 10:13 hgbot Note Added: 0120112
2020-05-21 10:13 hgbot Status scheduled => resolved
2020-05-21 10:13 hgbot Resolution open => fixed
2020-05-21 10:13 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/933ad6e5ac174128584f18ab61f7939ee017f5b1 [^]
2020-05-21 10:13 hgbot Checkin
2020-05-21 10:13 hgbot Note Added: 0120113
2020-05-21 10:14 dmiguelez Review Assigned To => dmiguelez
2020-05-21 10:14 dmiguelez Note Added: 0120114
2020-05-21 10:14 dmiguelez Status resolved => closed
2022-09-06 17:18 caristu Category Advance Warehouse Operations => Advanced Warehouse Operations

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker