Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044054ModulesAdvanced Warehouse Operationspublic2020-05-13 16:172020-05-21 10:14
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customer
Regression introduced in release
Summary0044054: Apply new HQL Style in InternalRoutingAssignmentUtils.java
DescriptionInternalRoutingAssignmentUtils.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-13 16:17inigo_lergaNew Issue
2020-05-13 16:17inigo_lergaAssigned To => inigo_lerga
2020-05-13 16:17inigo_lergaRelationship addedrelated to 0041287
2020-05-13 16:18inigo_lergaStatusnew => scheduled
2020-05-14 09:17inigo_lergaNote Added: 0119852
2020-05-15 11:57inigo_lergaNote Edited: 0119852bug_revision_view_page.php?bugnote_id=0119852#r21036
2020-05-15 11:58inigo_lergaNote Edited: 0119852bug_revision_view_page.php?bugnote_id=0119852#r21038
2020-05-21 10:13hgbotCheckin
2020-05-21 10:13hgbotNote Added: 0120112
2020-05-21 10:13hgbotStatusscheduled => resolved
2020-05-21 10:13hgbotResolutionopen => fixed
2020-05-21 10:13hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/933ad6e5ac174128584f18ab61f7939ee017f5b1 [^]
2020-05-21 10:13hgbotCheckin
2020-05-21 10:13hgbotNote Added: 0120113
2020-05-21 10:14dmiguelezReview Assigned To => dmiguelez
2020-05-21 10:14dmiguelezNote Added: 0120114
2020-05-21 10:14dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0119852)
inigo_lerga   
2020-05-14 09:17   
(edited on: 2020-05-15 11:58)
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
Execute the AWOTestSuite.java JUnit tests file.
#In this moment the modified HQLs are executed#
(0120112)
hgbot   
2020-05-21 10:13   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 933ad6e5ac174128584f18ab61f7939ee017f5b1
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Thu May 14 09:17:23 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/933ad6e5ac174128584f18ab61f7939ee017f5b1 [^]

fixes BUG-44054:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/task/InternalRoutingAssignmentUtils.java
---
(0120113)
hgbot   
2020-05-21 10:13   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 06e0c21fa2f482d74327e5f74db7876db1f563e6
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu May 21 10:10:34 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/06e0c21fa2f482d74327e5f74db7876db1f563e6 [^]

Related to ISSUE-44054. Code Review changes
  * Removed formatter on/off to improve redability of the query
  * collapse some hql sentences to make them easier to read
  * Use class constants for ordering priority instead of hardcoded numbers

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/task/InternalRoutingAssignmentUtils.java
---
(0120114)
dmiguelez   
2020-05-21 10:14   
Code Review + Testing Ok