Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0044023
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Advanced Warehouse Operationsminorhave not tried2020-05-11 13:592020-05-19 17:29
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisionc844f04e2fb8
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Regression introduced in release
Summary

0044023: Apply new HQL Style in OBAWOMobileUtils.java

DescriptionOBAWOMobileUtils.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0041287 acknowledgedTriage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 

-  Notes
(0119808)
inigo_lerga (reporter)
2020-05-13 11:16

 --Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.

To test this query , this line needs to be added to the code:
"OBContext.getOBContext().setWarehouse(null);"
Right at the beginning of getValidWarehouseId function
definition

As the AWO_US_W role in AWO Front End:
  - Log in to AWO Front End

  #In this moment the modified HQL is executed#
(0120062)
hgbot (developer)
2020-05-19 17:28

 Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: c844f04e2fb82ad13745720d1707b93dc9d48433
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed May 13 11:13:56 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/c844f04e2fb82ad13745720d1707b93dc9d48433 [^]

fixes BUG-44023:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/OBAWOMobileUtils.java
---
(0120063)
hgbot (developer)
2020-05-19 17:28

 Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 7ee25baad001d199a1824524d16c63c50fee2dc7
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Tue May 19 17:28:22 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/7ee25baad001d199a1824524d16c63c50fee2dc7 [^]

Related to ISSUE-44023. Centralized duplicated code into one method

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/OBAWOMobileUtils.java
---
(0120064)
dmiguelez (developer)
2020-05-19 17:29

 Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-05-11 13:59 inigo_lerga New Issue
2020-05-11 13:59 inigo_lerga Assigned To => inigo_lerga
2020-05-11 14:00 inigo_lerga Relationship added related to 0041287
2020-05-11 14:00 inigo_lerga Status new => scheduled
2020-05-13 11:16 inigo_lerga Note Added: 0119808
2020-05-19 17:28 hgbot Checkin
2020-05-19 17:28 hgbot Note Added: 0120062
2020-05-19 17:28 hgbot Status scheduled => resolved
2020-05-19 17:28 hgbot Resolution open => fixed
2020-05-19 17:28 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/c844f04e2fb82ad13745720d1707b93dc9d48433 [^]
2020-05-19 17:28 hgbot Checkin
2020-05-19 17:28 hgbot Note Added: 0120063
2020-05-19 17:29 dmiguelez Review Assigned To => dmiguelez
2020-05-19 17:29 dmiguelez Note Added: 0120064
2020-05-19 17:29 dmiguelez Status resolved => closed
2022-09-06 17:18 caristu Category Advance Warehouse Operations => Advanced Warehouse Operations

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker