Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044023ModulesAdvanced Warehouse Operationspublic2020-05-11 13:592020-05-19 17:29
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customer
Regression introduced in release
Summary0044023: Apply new HQL Style in OBAWOMobileUtils.java
DescriptionOBAWOMobileUtils.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-11 13:59inigo_lergaNew Issue
2020-05-11 13:59inigo_lergaAssigned To => inigo_lerga
2020-05-11 14:00inigo_lergaRelationship addedrelated to 0041287
2020-05-11 14:00inigo_lergaStatusnew => scheduled
2020-05-13 11:16inigo_lergaNote Added: 0119808
2020-05-19 17:28hgbotCheckin
2020-05-19 17:28hgbotNote Added: 0120062
2020-05-19 17:28hgbotStatusscheduled => resolved
2020-05-19 17:28hgbotResolutionopen => fixed
2020-05-19 17:28hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/c844f04e2fb82ad13745720d1707b93dc9d48433 [^]
2020-05-19 17:28hgbotCheckin
2020-05-19 17:28hgbotNote Added: 0120063
2020-05-19 17:29dmiguelezReview Assigned To => dmiguelez
2020-05-19 17:29dmiguelezNote Added: 0120064
2020-05-19 17:29dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0119808)
inigo_lerga   
2020-05-13 11:16   
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.

To test this query , this line needs to be added to the code:
"OBContext.getOBContext().setWarehouse(null);"
Right at the beginning of getValidWarehouseId function
definition

As the AWO_US_W role in AWO Front End:
  - Log in to AWO Front End

  #In this moment the modified HQL is executed#
(0120062)
hgbot   
2020-05-19 17:28   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: c844f04e2fb82ad13745720d1707b93dc9d48433
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed May 13 11:13:56 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/c844f04e2fb82ad13745720d1707b93dc9d48433 [^]

fixes BUG-44023:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/OBAWOMobileUtils.java
---
(0120063)
hgbot   
2020-05-19 17:28   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 7ee25baad001d199a1824524d16c63c50fee2dc7
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Tue May 19 17:28:22 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/7ee25baad001d199a1824524d16c63c50fee2dc7 [^]

Related to ISSUE-44023. Centralized duplicated code into one method

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/OBAWOMobileUtils.java
---
(0120064)
dmiguelez   
2020-05-19 17:29   
Code Review + Testing Ok