Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0044021 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Modules] Advanced Warehouse Operations | minor | have not tried | 2020-05-11 10:08 | 2020-05-19 16:25 | |||
| Reporter | inigo_lerga | View Status | public | |||||
| Assigned To | inigo_lerga | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | 73b30b08367d | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Regression date | ||||||||
| Regression introduced by commit | ||||||||
| Regression level | ||||||||
| Review Assigned To | dmiguelez | |||||||
| Regression introduced in release | ||||||||
| Summary | 0044021: Apply new HQL Style in Attribute.java | |||||||
| Description | Attribute.java has HQL queries with: - the HQL is hard to read because of formatting - and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default | |||||||
| Steps To Reproduce | - | |||||||
| Proposed Solution | Follow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^] | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||
|
|||||||||
 Relationships |
|
Notes |
|
|
(0119736) inigo_lerga (reporter) 2020-05-11 13:54 |
--Test Plan Mantis HQL-- Beforehand, the environment needs to have AWO modules installed and working. As the AWO-QA Admin - AWO-QA role: - Go to the Attribute window and create a new record with any name desired for the US Organization. Save the record. As the AWO_US_W role in AWO Front End: - Open AWO Front End. #In this moment the modified HQLs are executed# |
|
(0120052) hgbot (developer) 2020-05-19 16:24 |
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations Changeset: 73b30b08367d2c604fb1622581d21c476ab888dd Author: Iñigo Lerga <inigo.lerga <at> openbravo.com> Date: Mon May 11 13:57:12 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/73b30b08367d2c604fb1622581d21c476ab888dd [^] fixes BUG-44021:Applied new HQL Style --- M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/master/Attribute.java --- |
|
(0120053) hgbot (developer) 2020-05-19 16:24 |
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations Changeset: 831c4d707f785cfdbb348b4e235870462a8489fd Author: David Miguelez <david.miguelez <at> openbravo.com> Date: Tue May 19 16:24:23 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/831c4d707f785cfdbb348b4e235870462a8489fd [^] Related to ISSUE-44021. Code Review changes: * Remove new lines to improve redability * Remove variables to build query by pieces and create two small queries --- M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/master/Attribute.java --- |
|
(0120054) dmiguelez (developer) 2020-05-19 16:25 |
Code Review + Testing Ok |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2020-05-11 10:08 | inigo_lerga | New Issue | |
| 2020-05-11 10:08 | inigo_lerga | Assigned To | => inigo_lerga |
| 2020-05-11 10:08 | inigo_lerga | Relationship added | related to 0041287 |
| 2020-05-11 10:08 | inigo_lerga | Status | new => scheduled |
| 2020-05-11 13:54 | inigo_lerga | Note Added: 0119736 | |
| 2020-05-19 16:24 | hgbot | Checkin | |
| 2020-05-19 16:24 | hgbot | Note Added: 0120052 | |
| 2020-05-19 16:24 | hgbot | Status | scheduled => resolved |
| 2020-05-19 16:24 | hgbot | Resolution | open => fixed |
| 2020-05-19 16:24 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/73b30b08367d2c604fb1622581d21c476ab888dd [^] |
| 2020-05-19 16:24 | hgbot | Checkin | |
| 2020-05-19 16:24 | hgbot | Note Added: 0120053 | |
| 2020-05-19 16:25 | dmiguelez | Review Assigned To | => dmiguelez |
| 2020-05-19 16:25 | dmiguelez | Note Added: 0120054 | |
| 2020-05-19 16:25 | dmiguelez | Status | resolved => closed |
| 2022-09-06 17:18 | caristu | Category | Advance Warehouse Operations => Advanced Warehouse Operations |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |