Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044021ModulesAdvanced Warehouse Operationspublic2020-05-11 10:082020-05-19 16:25
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customerNo
Regression introduced in release
Summary0044021: Apply new HQL Style in Attribute.java
DescriptionAttribute.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-11 10:08inigo_lergaNew Issue
2020-05-11 10:08inigo_lergaAssigned To => inigo_lerga
2020-05-11 10:08inigo_lergaOBNetwork customer => No
2020-05-11 10:08inigo_lergaRelationship addedrelated to 0041287
2020-05-11 10:08inigo_lergaStatusnew => scheduled
2020-05-11 13:54inigo_lergaNote Added: 0119736
2020-05-19 16:24hgbotCheckin
2020-05-19 16:24hgbotNote Added: 0120052
2020-05-19 16:24hgbotStatusscheduled => resolved
2020-05-19 16:24hgbotResolutionopen => fixed
2020-05-19 16:24hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/73b30b08367d2c604fb1622581d21c476ab888dd [^]
2020-05-19 16:24hgbotCheckin
2020-05-19 16:24hgbotNote Added: 0120053
2020-05-19 16:25dmiguelezReview Assigned To => dmiguelez
2020-05-19 16:25dmiguelezNote Added: 0120054
2020-05-19 16:25dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0119736)
inigo_lerga   
2020-05-11 13:54   
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.

As the AWO-QA Admin - AWO-QA role:
  - Go to the Attribute window and create a new record with any name desired
    for the US Organization. Save the record.

As the AWO_US_W role in AWO Front End:
  - Open AWO Front End.

#In this moment the modified HQLs are executed#
(0120052)
hgbot   
2020-05-19 16:24   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 73b30b08367d2c604fb1622581d21c476ab888dd
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Mon May 11 13:57:12 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/73b30b08367d2c604fb1622581d21c476ab888dd [^]

fixes BUG-44021:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/master/Attribute.java
---
(0120053)
hgbot   
2020-05-19 16:24   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 831c4d707f785cfdbb348b4e235870462a8489fd
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Tue May 19 16:24:23 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/831c4d707f785cfdbb348b4e235870462a8489fd [^]

Related to ISSUE-44021. Code Review changes:
  * Remove new lines to improve redability
  * Remove variables to build query by pieces and create two small queries

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/master/Attribute.java
---
(0120054)
dmiguelez   
2020-05-19 16:25   
Code Review + Testing Ok