Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0043995
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Advanced Warehouse Operationsminorhave not tried2020-05-08 09:422020-05-19 13:39
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision7b47f9587921
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Regression introduced in release
Summary

0043995: Apply new HQL Style in TGC_SalesOrder_Pick.java

DescriptionTGC_SalesOrder_Pick.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0041287 acknowledgedTriage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 

-  Notes
(0119689)
inigo_lerga (reporter)
2020-05-08 12:05
edited on: 2020-05-08 14:20

 --Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.

As the AWO-QA Admin - AWO-QA role:
  - Go to the Sales Order window and create a new record
    with any Business Partner desired.
    Go to Lines Tab and create a new Line with any product and
    quantity desired.
    Book the Sales Order and copy the Search Key.

As the AWO_US_W role in AWO Front End:
  - Open the Pick window and paste the Search Key. Press search button.

  #In this moment the modified HQL is executed#
(0120033)
hgbot (developer)
2020-05-19 13:38

 Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 7b47f9587921eb00d5277ff6c4cefe78ec09ec94
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Fri May 08 11:49:27 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/7b47f9587921eb00d5277ff6c4cefe78ec09ec94 [^]

fixes BUG-43995:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/datasources/taskgenerationcandidates/TGC_SalesOrder_Pick.java
---
(0120034)
hgbot (developer)
2020-05-19 13:38

 Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: cc5985d88bb46d0063fd61f5f82e18ccd352dfc0
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Tue May 19 13:38:17 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/cc5985d88bb46d0063fd61f5f82e18ccd352dfc0 [^]

Related to ISSUE 43995. Refactor of class
* Logic to create additional where clause extracted to different method
* Added final modifiers
* Remove unnecessary writableOrgsInClause variable

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/datasources/taskgenerationcandidates/TGC_SalesOrder_Pick.java
---
(0120035)
dmiguelez (developer)
2020-05-19 13:39

 Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-05-08 09:42 inigo_lerga New Issue
2020-05-08 09:42 inigo_lerga Assigned To => inigo_lerga
2020-05-08 09:42 inigo_lerga Relationship added related to 0041287
2020-05-08 09:42 inigo_lerga Status new => scheduled
2020-05-08 12:05 inigo_lerga Note Added: 0119689
2020-05-08 14:20 inigo_lerga Note Edited: 0119689 View Revisions
2020-05-08 14:20 inigo_lerga Note Edited: 0119689 View Revisions
2020-05-19 13:38 hgbot Checkin
2020-05-19 13:38 hgbot Note Added: 0120033
2020-05-19 13:38 hgbot Status scheduled => resolved
2020-05-19 13:38 hgbot Resolution open => fixed
2020-05-19 13:38 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/7b47f9587921eb00d5277ff6c4cefe78ec09ec94 [^]
2020-05-19 13:38 hgbot Checkin
2020-05-19 13:38 hgbot Note Added: 0120034
2020-05-19 13:39 dmiguelez Review Assigned To => dmiguelez
2020-05-19 13:39 dmiguelez Note Added: 0120035
2020-05-19 13:39 dmiguelez Status resolved => closed
2022-09-06 17:18 caristu Category Advance Warehouse Operations => Advanced Warehouse Operations

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker