Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043995ModulesAdvanced Warehouse Operationspublic2020-05-08 09:422020-05-19 13:39
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customerNo
Regression introduced in release
Summary0043995: Apply new HQL Style in TGC_SalesOrder_Pick.java
DescriptionTGC_SalesOrder_Pick.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-08 09:42inigo_lergaNew Issue
2020-05-08 09:42inigo_lergaAssigned To => inigo_lerga
2020-05-08 09:42inigo_lergaOBNetwork customer => No
2020-05-08 09:42inigo_lergaRelationship addedrelated to 0041287
2020-05-08 09:42inigo_lergaStatusnew => scheduled
2020-05-08 12:05inigo_lergaNote Added: 0119689
2020-05-08 14:20inigo_lergaNote Edited: 0119689bug_revision_view_page.php?bugnote_id=0119689#r20990
2020-05-08 14:20inigo_lergaNote Edited: 0119689bug_revision_view_page.php?bugnote_id=0119689#r20991
2020-05-19 13:38hgbotCheckin
2020-05-19 13:38hgbotNote Added: 0120033
2020-05-19 13:38hgbotStatusscheduled => resolved
2020-05-19 13:38hgbotResolutionopen => fixed
2020-05-19 13:38hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/7b47f9587921eb00d5277ff6c4cefe78ec09ec94 [^]
2020-05-19 13:38hgbotCheckin
2020-05-19 13:38hgbotNote Added: 0120034
2020-05-19 13:39dmiguelezReview Assigned To => dmiguelez
2020-05-19 13:39dmiguelezNote Added: 0120035
2020-05-19 13:39dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0119689)
inigo_lerga   
2020-05-08 12:05   
(edited on: 2020-05-08 14:20)
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.

As the AWO-QA Admin - AWO-QA role:
  - Go to the Sales Order window and create a new record
    with any Business Partner desired.
    Go to Lines Tab and create a new Line with any product and
    quantity desired.
    Book the Sales Order and copy the Search Key.

As the AWO_US_W role in AWO Front End:
  - Open the Pick window and paste the Search Key. Press search button.

  #In this moment the modified HQL is executed#
(0120033)
hgbot   
2020-05-19 13:38   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 7b47f9587921eb00d5277ff6c4cefe78ec09ec94
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Fri May 08 11:49:27 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/7b47f9587921eb00d5277ff6c4cefe78ec09ec94 [^]

fixes BUG-43995:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/datasources/taskgenerationcandidates/TGC_SalesOrder_Pick.java
---
(0120034)
hgbot   
2020-05-19 13:38   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: cc5985d88bb46d0063fd61f5f82e18ccd352dfc0
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Tue May 19 13:38:17 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/cc5985d88bb46d0063fd61f5f82e18ccd352dfc0 [^]

Related to ISSUE 43995. Refactor of class
* Logic to create additional where clause extracted to different method
* Added final modifiers
* Remove unnecessary writableOrgsInClause variable

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/datasources/taskgenerationcandidates/TGC_SalesOrder_Pick.java
---
(0120035)
dmiguelez   
2020-05-19 13:39   
Code Review + Testing Ok