Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0043979 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Modules] Advanced Warehouse Operations | minor | have not tried | 2020-05-07 13:30 | 2020-05-18 18:56 | |||
| Reporter | inigo_lerga | View Status | public | |||||
| Assigned To | inigo_lerga | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | 86d86286e351 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Regression date | ||||||||
| Regression introduced by commit | ||||||||
| Regression level | ||||||||
| Review Assigned To | dmiguelez | |||||||
| Support ticket | ||||||||
| OBNetwork customer | No | |||||||
| Regression introduced in release | ||||||||
| Summary | 0043979: Apply new HQL Style in TGC_PurchaseOrder_Receipt.java | |||||||
| Description | TGC_PurchaseOrder_Receipt.java has HQL queries with: - the HQL is hard to read because of formatting - and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default | |||||||
| Steps To Reproduce | - | |||||||
| Proposed Solution | Follow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^] | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||
|
|||||||||
 Relationships |
|
Notes |
|
|
(0119661) inigo_lerga (viewer) 2020-05-07 14:36 |
--Test Plan Mantis HQL-- Beforehand, the environment needs to have AWO modules installed and working. As the AWO-QA Admin - AWO-QA role: - Go to the Purchase Order window and create a new record with any Business Partner desired. Go to Lines Tab and create a new Line with any product and quantity desired. Book the Purchase Order and copy the Search Key. As the AWO_US_W role in AWO Front End: - Open the Receive window and paste the Search Key. Press search button. #In this moment the modified HQL is executed# |
|
(0120002) hgbot (developer) 2020-05-18 18:18 |
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations Changeset: 86d86286e351b2d2d63bf5f98a51aba6ff78dd77 Author: Iñigo Lerga <inigo.lerga <at> openbravo.com> Date: Thu May 07 16:11:10 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/86d86286e351b2d2d63bf5f98a51aba6ff78dd77 [^] fixes BUG-43979:Applied new HQL Style --- M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/datasources/taskgenerationcandidates/TGC_PurchaseOrder_Receipt.java --- |
|
(0120003) hgbot (developer) 2020-05-18 18:18 |
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations Changeset: ed564fc9cb7735d2d7b8aea718daaa6bceaa31be Author: David Miguelez <david.miguelez <at> openbravo.com> Date: Mon May 18 18:18:03 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/ed564fc9cb7735d2d7b8aea718daaa6bceaa31be [^] Related to ISSUE-43979. Refactor of class * Logic to create additional where clause extracted to different method * Added final modifiers * Remove unnecessary writableOrgsInClause variable --- M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/datasources/taskgenerationcandidates/TGC_PurchaseOrder_Receipt.java --- |
|
(0120004) dmiguelez (viewer) 2020-05-18 18:19 |
Code Review + Testing Ok |
|
(0120007) hgbot (developer) 2020-05-18 18:56 |
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations Changeset: ad96ae68064ca51f7e8990e74734e6b66c0e5db4 Author: David Miguelez <david.miguelez <at> openbravo.com> Date: Mon May 18 18:55:56 2020 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/ad96ae68064ca51f7e8990e74734e6b66c0e5db4 [^] Related to ISSUE-43979. HQL format --- M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/datasources/taskgenerationcandidates/TGC_PurchaseOrder_Receipt.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2020-05-07 13:30 | inigo_lerga | New Issue | |
| 2020-05-07 13:30 | inigo_lerga | Assigned To | => inigo_lerga |
| 2020-05-07 13:30 | inigo_lerga | OBNetwork customer | => No |
| 2020-05-07 13:30 | inigo_lerga | Relationship added | related to 0041287 |
| 2020-05-07 13:30 | inigo_lerga | Status | new => scheduled |
| 2020-05-07 14:36 | inigo_lerga | Note Added: 0119661 | |
| 2020-05-18 18:18 | hgbot | Checkin | |
| 2020-05-18 18:18 | hgbot | Note Added: 0120002 | |
| 2020-05-18 18:18 | hgbot | Status | scheduled => resolved |
| 2020-05-18 18:18 | hgbot | Resolution | open => fixed |
| 2020-05-18 18:18 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/86d86286e351b2d2d63bf5f98a51aba6ff78dd77 [^] |
| 2020-05-18 18:18 | hgbot | Checkin | |
| 2020-05-18 18:18 | hgbot | Note Added: 0120003 | |
| 2020-05-18 18:19 | dmiguelez | Review Assigned To | => dmiguelez |
| 2020-05-18 18:19 | dmiguelez | Note Added: 0120004 | |
| 2020-05-18 18:19 | dmiguelez | Status | resolved => closed |
| 2020-05-18 18:56 | hgbot | Checkin | |
| 2020-05-18 18:56 | hgbot | Note Added: 0120007 | |
| 2022-09-06 17:18 | caristu | Category | Advance Warehouse Operations => Advanced Warehouse Operations |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |