Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043979ModulesAdvanced Warehouse Operationspublic2020-05-07 13:302020-05-18 18:56
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customerNo
Regression introduced in release
Summary0043979: Apply new HQL Style in TGC_PurchaseOrder_Receipt.java
DescriptionTGC_PurchaseOrder_Receipt.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-07 13:30inigo_lergaNew Issue
2020-05-07 13:30inigo_lergaAssigned To => inigo_lerga
2020-05-07 13:30inigo_lergaOBNetwork customer => No
2020-05-07 13:30inigo_lergaRelationship addedrelated to 0041287
2020-05-07 13:30inigo_lergaStatusnew => scheduled
2020-05-07 14:36inigo_lergaNote Added: 0119661
2020-05-18 18:18hgbotCheckin
2020-05-18 18:18hgbotNote Added: 0120002
2020-05-18 18:18hgbotStatusscheduled => resolved
2020-05-18 18:18hgbotResolutionopen => fixed
2020-05-18 18:18hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/86d86286e351b2d2d63bf5f98a51aba6ff78dd77 [^]
2020-05-18 18:18hgbotCheckin
2020-05-18 18:18hgbotNote Added: 0120003
2020-05-18 18:19dmiguelezReview Assigned To => dmiguelez
2020-05-18 18:19dmiguelezNote Added: 0120004
2020-05-18 18:19dmiguelezStatusresolved => closed
2020-05-18 18:56hgbotCheckin
2020-05-18 18:56hgbotNote Added: 0120007
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0119661)
inigo_lerga   
2020-05-07 14:36   
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.

As the AWO-QA Admin - AWO-QA role:
  - Go to the Purchase Order window and create a new record
    with any Business Partner desired.
    Go to Lines Tab and create a new Line with any product and
    quantity desired.
    Book the Purchase Order and copy the Search Key.

As the AWO_US_W role in AWO Front End:
  - Open the Receive window and paste the Search Key. Press search button.

  #In this moment the modified HQL is executed#
(0120002)
hgbot   
2020-05-18 18:18   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 86d86286e351b2d2d63bf5f98a51aba6ff78dd77
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Thu May 07 16:11:10 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/86d86286e351b2d2d63bf5f98a51aba6ff78dd77 [^]

fixes BUG-43979:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/datasources/taskgenerationcandidates/TGC_PurchaseOrder_Receipt.java
---
(0120003)
hgbot   
2020-05-18 18:18   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: ed564fc9cb7735d2d7b8aea718daaa6bceaa31be
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon May 18 18:18:03 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/ed564fc9cb7735d2d7b8aea718daaa6bceaa31be [^]

Related to ISSUE-43979. Refactor of class
  * Logic to create additional where clause extracted to different method
  * Added final modifiers
  * Remove unnecessary writableOrgsInClause variable

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/datasources/taskgenerationcandidates/TGC_PurchaseOrder_Receipt.java
---
(0120004)
dmiguelez   
2020-05-18 18:19   
Code Review + Testing Ok
(0120007)
hgbot   
2020-05-18 18:56   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: ad96ae68064ca51f7e8990e74734e6b66c0e5db4
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon May 18 18:55:56 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/ad96ae68064ca51f7e8990e74734e6b66c0e5db4 [^]

Related to ISSUE-43979. HQL format

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/datasources/taskgenerationcandidates/TGC_PurchaseOrder_Receipt.java
---