Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0043938
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Advanced Warehouse Operationsminorhave not tried2020-05-05 13:082020-05-15 11:58
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision56e3f49a5621
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Regression introduced in release
Summary

0043938: Apply new HQL Style in WarehouseConfigurationCheckHandler.java

DescriptionWarehouseConfigurationCheckHandler.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0041287 acknowledgedTriage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 

-  Notes
(0119585)
inigo_lerga (reporter)
2020-05-05 13:37
edited on: 2020-05-05 13:38

 --Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
As the AWO-QA Admin - AWO-QA role:
  - Go to the Warehouse Configuration Check window. Select any desired values
    in the available fields and press the Done button.

  #In this moment the modified HQL is executed#
(0119940)
hgbot (developer)
2020-05-15 11:57

 Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 56e3f49a5621f1a959998c535db2405aff43af97
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue May 05 13:42:35 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/56e3f49a5621f1a959998c535db2405aff43af97 [^]

fixes BUG-43938:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/handler/WarehouseConfigurationCheckHandler.java
---
(0119941)
hgbot (developer)
2020-05-15 11:57

 Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 53009192a5f83f87998cb88e56f31daf4c2c152a
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Fri May 15 11:54:44 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/53009192a5f83f87998cb88e56f31daf4c2c152a [^]

Related to ISSUE-43938. Return the list directly avoiding using the query variable

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/handler/WarehouseConfigurationCheckHandler.java
---
(0119942)
dmiguelez (developer)
2020-05-15 11:58

 Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-05-05 13:08 inigo_lerga New Issue
2020-05-05 13:08 inigo_lerga Assigned To => inigo_lerga
2020-05-05 13:09 inigo_lerga Relationship added related to 0041287
2020-05-05 13:09 inigo_lerga Status new => scheduled
2020-05-05 13:37 inigo_lerga Note Added: 0119585
2020-05-05 13:38 inigo_lerga Note Edited: 0119585 View Revisions
2020-05-15 11:57 hgbot Checkin
2020-05-15 11:57 hgbot Note Added: 0119940
2020-05-15 11:57 hgbot Status scheduled => resolved
2020-05-15 11:57 hgbot Resolution open => fixed
2020-05-15 11:57 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/56e3f49a5621f1a959998c535db2405aff43af97 [^]
2020-05-15 11:57 hgbot Checkin
2020-05-15 11:57 hgbot Note Added: 0119941
2020-05-15 11:58 dmiguelez Review Assigned To => dmiguelez
2020-05-15 11:58 dmiguelez Note Added: 0119942
2020-05-15 11:58 dmiguelez Status resolved => closed
2022-09-06 17:18 caristu Category Advance Warehouse Operations => Advanced Warehouse Operations

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker