Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0043938ModulesAdvanced Warehouse Operationspublic2020-05-05 13:082020-05-15 11:58
Reporterinigo_lerga 
Assigned Toinigo_lerga 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customer
Regression introduced in release
Summary0043938: Apply new HQL Style in WarehouseConfigurationCheckHandler.java
DescriptionWarehouseConfigurationCheckHandler.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-05-05 13:08inigo_lergaNew Issue
2020-05-05 13:08inigo_lergaAssigned To => inigo_lerga
2020-05-05 13:09inigo_lergaRelationship addedrelated to 0041287
2020-05-05 13:09inigo_lergaStatusnew => scheduled
2020-05-05 13:37inigo_lergaNote Added: 0119585
2020-05-05 13:38inigo_lergaNote Edited: 0119585bug_revision_view_page.php?bugnote_id=0119585#r20944
2020-05-15 11:57hgbotCheckin
2020-05-15 11:57hgbotNote Added: 0119940
2020-05-15 11:57hgbotStatusscheduled => resolved
2020-05-15 11:57hgbotResolutionopen => fixed
2020-05-15 11:57hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/56e3f49a5621f1a959998c535db2405aff43af97 [^]
2020-05-15 11:57hgbotCheckin
2020-05-15 11:57hgbotNote Added: 0119941
2020-05-15 11:58dmiguelezReview Assigned To => dmiguelez
2020-05-15 11:58dmiguelezNote Added: 0119942
2020-05-15 11:58dmiguelezStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0119585)
inigo_lerga   
2020-05-05 13:37   
(edited on: 2020-05-05 13:38)
--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
As the AWO-QA Admin - AWO-QA role:
  - Go to the Warehouse Configuration Check window. Select any desired values
    in the available fields and press the Done button.

  #In this moment the modified HQL is executed#
(0119940)
hgbot   
2020-05-15 11:57   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 56e3f49a5621f1a959998c535db2405aff43af97
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Tue May 05 13:42:35 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/56e3f49a5621f1a959998c535db2405aff43af97 [^]

fixes BUG-43938:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/handler/WarehouseConfigurationCheckHandler.java
---
(0119941)
hgbot   
2020-05-15 11:57   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 53009192a5f83f87998cb88e56f31daf4c2c152a
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Fri May 15 11:54:44 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/53009192a5f83f87998cb88e56f31daf4c2c152a [^]

Related to ISSUE-43938. Return the list directly avoiding using the query variable

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/handler/WarehouseConfigurationCheckHandler.java
---
(0119942)
dmiguelez   
2020-05-15 11:58   
Code Review + Testing Ok