Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0043874
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajorsometimes2020-04-27 08:362020-08-04 14:31
Reporterjorge-garciaView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityurgentResolutionfixedFixed in VersionRR20Q3
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0043874: Sessions module could execute twice callbaxkExecutor of OBPOS_LoadPOSWindow hook

DescriptionSometimes, sessions module hook OBPOS_LoadPOSWindow could execute twice the callbackExcutor, allowing the execution of the callback of OBPOS_LoadPOSWindow before all register hooks has finished.
Steps To Reproduce1) Login in WebPOS with sessions module, fill required steps
2) Put three breakpoints in the code:
    2.1) Before the execution of OBPOS_LoadPOSWindow hook:
      OB.UTIL.HookManager.executeHooks('OBPOS_LoadPOSWindow', {}, function(args) {
    2.2) In tillCallback function
      } else {
        OB.MobileApp.model.hookManager.callbackExecutor(args, callbacks);
      }
    2.3) At the end of session register hook for OBPOS_LoadPOSWindow:
        args.cancellation = true;
        OB.UTIL.HookManager.callbackExecutor(args, callbacks);
3) Copy this code in Developers Tools:
  OB.UTIL.HookManager.registerHook('OBPOS_LoadPOSWindow', function(args, callbacks) {
    OB.UTIL.showConfirmation.display('Hola', 'hola', [{
      label: OB.I18N.getLabel('OBMOBC_LblOk'),
      isConfirmButton: true,
      action: function () {
        debugger;
        OB.UTIL.HookManager.callbackExecutor(args, callbacks);
      }
    }]);
  });
4) If no business partner is required to set, no initial count cash is needed to be counted, and no cashup is required to be done, the logic of sessions hook calls twice to the callbackExecutor, making the logic of the executeHook to continue before the copied hook has finisehd (it ends once the ok button from popup is clicked).
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
caused by defect 0043333 closedrqueralta The login hook is not executed when login after a cashup 

-  Notes
(0119446)
hgbot (developer)
2020-04-28 04:55

 Repository: erp/pmods/org.openbravo.retail.sessions
Changeset: 1de0d222cd8aa89dde3cc875df7c48b1950d6ac7
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Apr 28 08:25:13 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/1de0d222cd8aa89dde3cc875df7c48b1950d6ac7 [^]

Related to issue-43874 : Refactored hookCallback in OBPOS_LoadPOSWindow hook

* Removed unwannted hook Callback

---
M web/org.openbravo.retail.sessions/js/components/loginhook.js
M web/org.openbravo.retail.sessions/js/countcash/countcash-model.js
---

- Issue History
Date Modified Username Field Change
2020-04-27 08:36 jorge-garcia New Issue
2020-04-27 08:36 jorge-garcia Assigned To => Retail
2020-04-27 08:36 jorge-garcia Triggers an Emergency Pack => No
2020-04-27 08:38 jorge-garcia Resolution time => 1589752800
2020-04-27 08:45 jorge-garcia Priority normal => urgent
2020-04-27 10:26 adrianromero Relationship added caused by 0043333
2020-04-27 13:18 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2020-04-27 15:34 jorge-garcia Issue Monitored: jorge-garcia
2020-04-28 04:55 hgbot Checkin
2020-04-28 04:55 hgbot Note Added: 0119446
2020-04-28 04:55 ranjith_qualiantech_com Status new => scheduled
2020-04-28 06:03 hgbot Checkin
2020-04-28 06:03 hgbot Note Added: 0119448
2020-04-28 08:42 hgbot Checkin
2020-04-28 08:42 hgbot Note Added: 0119453
2020-04-28 08:52 ranjith_qualiantech_com Note Deleted: 0119453
2020-04-28 08:53 ranjith_qualiantech_com Note Deleted: 0119448
2020-04-28 08:53 ranjith_qualiantech_com Status scheduled => resolved
2020-04-28 08:53 ranjith_qualiantech_com Resolution open => fixed
2020-04-29 18:02 marvintm Review Assigned To => marvintm
2020-04-29 18:02 marvintm Status resolved => closed
2020-04-29 18:02 marvintm Fixed in Version => RR20Q3
2020-05-05 03:02 hgbot Checkin
2020-05-05 03:02 hgbot Note Added: 0119535
2020-05-05 03:03 ranjith_qualiantech_com Note Deleted: 0119535
2020-08-04 14:30 adrianromero Note Added: 0121804
2020-08-04 14:30 adrianromero Status closed => new
2020-08-04 14:30 adrianromero Resolution fixed => open
2020-08-04 14:30 adrianromero Fixed in Version RR20Q3 =>
2020-08-04 14:31 adrianromero Note Deleted: 0121804
2020-08-04 14:31 adrianromero Status new => scheduled
2020-08-04 14:31 adrianromero Status scheduled => resolved
2020-08-04 14:31 adrianromero Fixed in Version => RR20Q3
2020-08-04 14:31 adrianromero Resolution open => fixed
2020-08-04 14:31 adrianromero Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker